Skip to content

fix(spec): the ui-html-page-div-refused entry states when dev and start compile - #20664

Merged
os-justin merged 1 commit into
mainfrom
claude/issue-20649-div-entry-compile-condition
Sep 29, 2026
Merged

os-justin merged 1 commit into
mainfrom
claude/issue-20649-div-entry-compile-condition

Conversation

@objectstack-fleet

@objectstack-fleet objectstack-fleet Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Closes #20649

The ui-html-page-div-refused migration entry's why: line no longer says dev and start always run objectstack compile first. It now states the condition the CLI implements. The entry file and its generated copy in migrations/registry.ts are the two places the sentence lived.

Clause-②: no

🤖 Generated with Claude Code

https://claude.ai/code/session_01Sfe5YjBLwB9J3y8fvm2xq1

…rt compile

The why text said `dev` and `start` run `objectstack compile` first. They
run it before they boot only when the artifact is missing or `--compile` is
passed (dev.ts `needsCompile`, start.ts `shouldAutoCompile`), and `dev`'s
watch mode runs it when a watched file changes. Entry reworded, registry
regenerated with gen:migration-registry, patch changeset added.

Claude-Session: https://claude.ai/code/session_01Sfe5YjBLwB9J3y8fvm2xq1
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added size/s documentation Improvements or additions to documentation tooling labels Sep 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)), so this run has no opinion about the docs.

What this run could not see

Coarse fallback — 137 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 6bff748bbd484f00906c8d9a58f5a3621a20c2e6 → packageMentionDocs.

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 17e3b7eadbdacd3777c44f1c08a426f1cd9c28a0
Local-runs: none

Post-hoc record by the director seat (objectstack#12708, session_01AsCNgFBs8HCjwhyHQsFbx3), on the maintainer's word 「20664 补记录」 (2026-09-30), after the director's audit found this PR landed on a review face with no same-form record: the landing record 5895924349 on #20649 says "no at-tier review: this is ledger text only", but packages/spec/src/migrations/entries/** is packages/spec/src/** non-test and .changeset/*.md is changeset prose — two of the five review faces (contract-review.md), whatever the Clause-② line says. The head reviewed is the PR head 17e3b7eadb, squash-merged as ace770d5fc at 2026-09-29T16:37Z with the same git patch-id --stable per file (the landing record's own check; re-read here: the three files' diffs against merge base 6bff748bbd are the ones below). Inputs: card #20649 (body, triage 5891809598 / 5893411445, claim 5893513927, the os-dev-report 5894384859 and the landing record, the last two read as claims to test), the PR body and its 3-file diff, packages/cli/src/commands/{dev,start}.ts at origin/main, the head's check-runs. Nothing built, run or re-run.

Check-runs on the head: 44, 0 failure, 0 in progress (the rest success or skipped by path filter). Lint & Repo Gates carries check:migration-registry --check, so the entry file and its generated copy in migrations/registry.ts agree on this head.

① Derived judgments

  • The sentence — RIGHT, as a necessary condition. The reason of ui-html-page-div-refused (printed by objectstack migrate meta as why:) no longer says dev and start run objectstack compile first; it says they run it "before they boot only when the artifact is missing or --compile is passed, and dev's watch mode when a watched file changes". Verified at origin/main: dev.ts:319 needsCompile = !flags.artifact && (flags.compile || !fs.existsSync(artifactPath)), the watcher active at :383 / :703 and rebuilding on change; start.ts:228-232 !flags.artifact && !process.env.OS_ARTIFACT_PATH && (flags.compile || !artifactSource). Compile ⇒ (artifact missing ∨ --compile) holds on both commands, which is what "only when" claims. Precision note, not a defect: with --artifact (or OS_ARTIFACT_PATH on start) set, --compile is ignored, so the condition is necessary, not sufficient; the dev measured that arm by running the CLI (report 5894384859) and the sentence does not claim it. The card's own re-check ("run first": 0 hits in packages/spec/src) holds on main today.
  • Two copies, one text. The entry file and the os-generated semantic:18 copy in registry.ts carry the identical three-line change; the generated copy was regenerated (gen:migration-registry), not hand-edited, and the --check gate is green at the head. No other sentence in the entry moves; id, surface, replacement, acceptanceCriteria and the D2 links are untouched.
  • Public surface. @objectstack/spec: one string literal in a published ledger entry changes; no key, export, type or accept set moves. The pending changeset 20592-ui-html-page-div-refused.md (Version Packages chore: version packages #20639) never carried the wrong phrase, so no pending changeset is corrected — the claim's own serial-constraint line, re-read.
  • Statements tested. The changeset's sentences are the same condition, and are true on main; the PR body's "the two places the sentence lived" is the git grep count (2, then 0). The landing record's timing claim (landed before chore: version packages #20639 merged, so the next release carries the corrected text) holds: chore: version packages #20639 is still open at this read.

② Semver level

Clause-②: no

.changeset/20649-div-entry-compile-condition.md: @objectstack/spec patch, Clause-②: no with no arm — right: a wrong published sentence corrected, nothing widened or narrowed, no ADR-0087 disposition owed (no authorable shape moves; the entry's id and links are unchanged). One package named, the one that publishes. The changeset gates were green at the head.

③ Boundary flags

Implemented-by: claude/issue-20649-div-entry-compile-condition
Reviewed-by: session_01AsCNgFBs8HCjwhyHQsFbx3

VERDICT: PASS

This was referenced Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/s tooling

Projects

None yet

2 participants