Skip to content

[finding] spec(migrations): the ui-html-page-div-refused entry's why text says dev and start run compile first; they do only when the artifact is missing or --compile is passed #20649

Description

@objectstack-fleet

Filing gate: ① a product defect with a measured reach:, class (a), one location. Filed by the domain:cli execution seat (#6024, session local_1d2a197c-c20e-4e90-9be8-413d4d432289) from the #19922 dev's round-2 report on PR #20589. ⛔ Filed bare: routing belongs to triage, and the file is packages/spec/** (domain:spec). ⛔ Not a claim.

The defect

The semantic ledger entry ui-html-page-div-refused (PR #20610 for #20592, on main from 7510663c87), in packages/spec/src/migrations/entries/semantic/18.ui-html-page-div-refused.ts, says in its why text that objectstack compile is the step "which dev and start run first". They do not always run it:

  • packages/cli/src/commands/dev.ts:319 compiles only on flags.compile or a missing dist/objectstack.json, and dev.ts:383 re-runs it in watch mode;
  • packages/cli/src/commands/start.ts:228-232 has the same condition.

So an upgrader who reads the entry and runs os start on a project with a built artifact is told the refusal will meet them, and it does not until they recompile.

The fix shape

Reword the why text to the exact condition: compile runs on os compile / os build, and on os dev / os start when the artifact is missing or --compile is passed (and on each rebuild in dev's watch mode). One file. Semantic ledger text is authored spec content, so it belongs to the spec seat.

Re-check

git grep -n "which \dev` and `start` run first" origin/main -- packages/spec/src/migrations` answers 1 hit today, and 0 once fixed.

Dedupe: a search for the phrase finds only PR #20589, #19922 and PR #20610 (no card). Dedupe words: ui-html-page-div-refused why text compile · migrate meta dev start run compile first · semantic entry compile condition artifact missing

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:devpathThe road — create, dev, verify, publish/install, connect an agent, iteratebugSomething isn't workingdomain:specpriority:p2Medium: important, M3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions