TUL/Reduce the footer vendor credit to the company name - #1466
Merged
Conversation
The footer credit read "Theme by" stacked above "+ dataquest". Drop the wording and leave the company name on its own. The wording was hard-coded in the template here, not translated, so there is no i18n key to remove. The .theme-by SCSS rule is deleted along with the element it styled. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MatusBeke
added a commit
that referenced
this pull request
Aug 18, 2026
Collaborator
Author
|
Footer as it renders with this branch — TUL theme, production build against a local DSpace 7.5 backend:
The credit is now just |
There was a problem hiding this comment.
Pull request overview
This PR simplifies the footer’s vendor credit by removing the “Theme by” line, leaving only the company name/link (as agreed in the referenced rollout for other customers).
Changes:
- Removed the
Theme by<p>element fromfooter.component.htmlwhile leaving the existing vendor link intact. - Removed the now-unused
.theme-bystyling fromfooter.component.scss.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/app/footer/footer.component.html |
Deletes the “Theme by” line so only the vendor link text remains. |
src/app/footer/footer.component.scss |
Removes the .theme-by rule since the element no longer exists. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the
Theme bywording from the footer's vendor credit and leaves the company name on its own.Part of dataquest-dev/dspace-customers#592. Same change as #1464 (MENDELU), which the team agreed on after voting between several wordings. Rolling out to the remaining customers one branch at a time.
Before / after
Theme byon its own line,+ dataquestunderneath+ dataquestaloneScreenshot below.
What changed
Five deleted lines, nothing added.
footer.component.html— the<p class="theme-by">Theme by</p>above the link is gone. The anchor itself is untouched, so its[href],[title]and hard-coded+ dataquesttext all behave exactly as before.footer.component.scss— the.theme-byrule (padding-top: 4px; font-size: 12px !important) is deleted along with the element it styled; it had no other use.Note that on this branch the wording was hard-coded in the template rather than translated, so unlike MENDELU there is no i18n key to remove.
Verification
Built the production image from this branch and ran it against a local DSpace 7.5 backend with
themed.by.*exposed:+ dataquest.theme-byelementhrefhttps://www.dataquest.sk/dspacetitle+ dataquest(fromthemed.by.company.name)Notes for the reviewer
DSpace software copyright © 2002-2026 LYRASISline above is untouched, so the software copyright and the vendor credit stay clearly separate.+in+ dataquestis part of the text on this branch; on other customers it comes from the backend property.🤖 Generated with Claude Code