ZCU/Reduce the footer vendor credit to the company name - #1468
Conversation
The footer credit read "Theme by" stacked above the company name. Drop the wording and leave the name on its own. The i18n key footer.theme.by.message is now unused and removed from en.json5; cs.json5 on this branch never carried it. The anchor itself is untouched, so its rendering — including the *ngVar binding and the [href] — behaves exactly as before. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes the “Theme by” label from the footer vendor credit so only the backend-provided company name is shown, and cleans up the now-unused EN i18n key.
Changes:
- Removed the translated
footer.theme.by.messageline from the footer template. - Removed the unused
footer.theme.by.messagekey fromen.json5.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/footer/footer.component.html | Removes the “Theme by” label above the vendor credit link in the footer. |
| src/assets/i18n/en.json5 | Removes the now-unused translation key for the deleted footer label. |
Suppressed comments (1)
src/app/footer/footer.component.html:100
- The vendor credit is always rendered by *ngVar, even when
themed.by.company.nameis missing/404s; in that casecompanyNameis undefined and the footer contains an empty link (no discernible text/title), which is an accessibility failure and can break a11y e2e checks. Guard rendering on a non-empty company name (and use safe array access to avoidvaluesbeing undefined).
<a class="dtq-sign text-white" *ngVar="(themedByCompanyName$ | async)?.payload?.values[0] as companyName"
[href]="(themedByUrl$ | async)?.payload?.values[0]"
[title]="companyName">
{{ companyName }}
</a>
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Built and rendered from this exact branch after all — the PR description says I skipped it, that no longer applies. Production build of
The |

Drops the
Theme bywording from the footer's vendor credit and leaves the company name on its own.Part of dataquest-dev/dspace-customers#592, following #1464 (MENDELU), #1466 (TUL) and #1467 (ZCU public).
Before / after
Theme byon its own line,+ dataquestunderneath+ dataquestaloneWhat changed
Three deleted lines, nothing added.
src/app/footer/footer.component.html— the<p class="theme-by">above the link is gone. The anchor is untouched: its*ngVarbinding,[href]and[title]behave exactly as before, and the name still comes from the backend propertythemed.by.company.name.en.json5—footer.theme.by.messageremoved, now unused.cs.json5on this branch never carried the key, so it is not touched.No new CSS; the credit keeps the footer's existing link styling.
Verification
This branch carries the same footer markup as
customer/zcu-pub— the only difference is that it lives insrc/app/footer/rather than in the theme — and the two branches share a byte-identicalyarn.lock. The rendering was verified on #1467, screenshot there:+ dataquest.theme-byelementhrefhttps://www.dataquest.sk/dspaceI did not stand up a separate build for this branch. If you would rather see a screenshot from this exact branch before merging, say so and I will produce one.
Notes for the reviewer
DSpace software copyright © 2002-2026 LYRASISline above is untouched.🤖 Generated with Claude Code