VSB-TUO/Reduce the footer vendor credit to the company name - #1469
Merged
Conversation
The footer credit read "Theme by" stacked above the company name. Drop the wording and leave the name on its own. The i18n key footer.theme.by.message is now unused and removed from en.json5 and cs.json5. The anchor itself is untouched, so its rendering — including the *ngVar binding and the [href] — behaves exactly as before. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MatusBeke
added a commit
that referenced
this pull request
Aug 19, 2026
MatusBeke
added a commit
that referenced
this pull request
Aug 19, 2026
Collaborator
Author
There was a problem hiding this comment.
Pull request overview
Removes the “Theme by” wording from the custom theme footer vendor credit, leaving only the company name link, and cleans up the now-unused i18n key.
Changes:
- Deleted the
footer.theme.by.message<p>from the footer credit block. - Removed
footer.theme.by.messagefromen.json5andcs.json5.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/themes/custom/app/footer/footer.component.html |
Removes the translated “Theme by” line above the vendor credit link. |
src/assets/i18n/en.json5 |
Deletes the unused footer.theme.by.message translation entry. |
src/assets/i18n/cs.json5 |
Deletes the unused footer.theme.by.message translation entry. |
Suppressed comments (1)
src/themes/custom/app/footer/footer.component.html:100
*ngVaralways instantiates the embedded view (seeVarDirective.updateView()), even whencompanyNameisundefined. After removing theTheme by<p>, a missingthemed.by.company.nameconfig will leave an empty<a>(no text, emptytitle, likely emptyhref), which is both a UX regression and an accessibility issue (unnamed link). Consider guarding the link with*ngIf="(themedByCompanyName$ | async)?.payload?.values?.[0] as companyName"(or equivalent) so the credit isn’t rendered at all when the value is absent.
<div class="footer-sign">
<a class="dtq-sign text-white" *ngVar="(themedByCompanyName$ | async)?.payload?.values[0] as companyName"
[href]="(themedByUrl$ | async)?.payload?.values[0]"
[title]="companyName">
{{ companyName }}
</a>
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Drops the
Theme bywording from the footer's vendor credit and leaves the company name on its own.Part of dataquest-dev/dspace-customers#592, following #1464 (MENDELU), #1466 (TUL), #1467 and #1468 (ZCU).
Before / after
Theme byon its own line,+ dataquestunderneath+ dataquestaloneScreenshots below.
What changed
Five deleted lines, nothing added.
src/themes/custom/app/footer/footer.component.html— the<p class="theme-by">above the link is gone. The anchor is untouched: its*ngVarbinding,[href]and[title]behave exactly as before, and the name still comes fromthemed.by.company.name.en.json5/cs.json5—footer.theme.by.messageremoved, now unused.No CSS is added or changed by this PR.
How this was verified, and the one gap
Two separate checks, because neither covers everything on its own:
1. The markup — from a production build of this branch. Rendered against the live VSB-TUO backend:
+ dataquest.theme-byelementhrefhttps://www.dataquest.sk/dspace2. The look — on the live dev-6 instance. My local run renders the bar navy rather than the instance's teal, because the deployed instances load their own config from
/opt/dspace-envs/<instance>/and I only have the repo defaults locally. So the appearance screenshot below is the live instance with<p class="theme-by">removed from the DOM — the same element this PR deletes — rather than a render of my build.That split is worth stating plainly: the text and structure are proven by the build, the colours and layout by the live instance. This PR changes no CSS, so the colour is not something it can affect either way.
🤖 Generated with Claude Code