Skip to content

VSB-TUO/Reduce the footer vendor credit to the company name - #1469

Merged
milanmajchrak merged 1 commit into
customer/vsb-tuofrom
vsb-tuo/fe-footer-dataquest-only
Aug 19, 2026
Merged

VSB-TUO/Reduce the footer vendor credit to the company name#1469
milanmajchrak merged 1 commit into
customer/vsb-tuofrom
vsb-tuo/fe-footer-dataquest-only

Conversation

@MatusBeke

Copy link
Copy Markdown
Collaborator

Drops the Theme by wording from the footer's vendor credit and leaves the company name on its own.

Part of dataquest-dev/dspace-customers#592, following #1464 (MENDELU), #1466 (TUL), #1467 and #1468 (ZCU).

Before / after

before Theme by on its own line, + dataquest underneath
after + dataquest alone

Screenshots below.

What changed

Five deleted lines, nothing added.

src/themes/custom/app/footer/footer.component.html — the <p class="theme-by"> above the link is gone. The anchor is untouched: its *ngVar binding, [href] and [title] behave exactly as before, and the name still comes from themed.by.company.name.

en.json5 / cs.json5footer.theme.by.message removed, now unused.

No CSS is added or changed by this PR.

How this was verified, and the one gap

Two separate checks, because neither covers everything on its own:

1. The markup — from a production build of this branch. Rendered against the live VSB-TUO backend:

rendered text + dataquest
.theme-by element not present in the DOM
href https://www.dataquest.sk/dspace
font-size / weight 16px / 400 — unchanged

2. The look — on the live dev-6 instance. My local run renders the bar navy rather than the instance's teal, because the deployed instances load their own config from /opt/dspace-envs/<instance>/ and I only have the repo defaults locally. So the appearance screenshot below is the live instance with <p class="theme-by"> removed from the DOM — the same element this PR deletes — rather than a render of my build.

That split is worth stating plainly: the text and structure are proven by the build, the colours and layout by the live instance. This PR changes no CSS, so the colour is not something it can affect either way.

🤖 Generated with Claude Code

The footer credit read "Theme by" stacked above the company name. Drop the
wording and leave the name on its own.

The i18n key footer.theme.by.message is now unused and removed from
en.json5 and cs.json5.

The anchor itself is untouched, so its rendering — including the *ngVar
binding and the [href] — behaves exactly as before.

Refs dataquest-dev/dspace-customers#592

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MatusBeke added a commit that referenced this pull request Aug 19, 2026
MatusBeke added a commit that referenced this pull request Aug 19, 2026
@MatusBeke

MatusBeke commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator Author

With <p class="theme-by"> removed — the element this PR deletes:

VSB-TUO footer without Theme by

The credit drops from two stacked lines to a single + dataquest. Bar colour rgb(0, 164, 153) and footer height 54px are identical in both — this PR adds no CSS, so it cannot affect them.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the “Theme by” wording from the custom theme footer vendor credit, leaving only the company name link, and cleans up the now-unused i18n key.

Changes:

  • Deleted the footer.theme.by.message <p> from the footer credit block.
  • Removed footer.theme.by.message from en.json5 and cs.json5.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/themes/custom/app/footer/footer.component.html Removes the translated “Theme by” line above the vendor credit link.
src/assets/i18n/en.json5 Deletes the unused footer.theme.by.message translation entry.
src/assets/i18n/cs.json5 Deletes the unused footer.theme.by.message translation entry.
Suppressed comments (1)

src/themes/custom/app/footer/footer.component.html:100

  • *ngVar always instantiates the embedded view (see VarDirective.updateView()), even when companyName is undefined. After removing the Theme by <p>, a missing themed.by.company.name config will leave an empty <a> (no text, empty title, likely empty href), which is both a UX regression and an accessibility issue (unnamed link). Consider guarding the link with *ngIf="(themedByCompanyName$ | async)?.payload?.values?.[0] as companyName" (or equivalent) so the credit isn’t rendered at all when the value is absent.
            <div class="footer-sign">
              <a class="dtq-sign text-white" *ngVar="(themedByCompanyName$ | async)?.payload?.values[0] as companyName"
                 [href]="(themedByUrl$ | async)?.payload?.values[0]"
                 [title]="companyName">
                {{ companyName }}
              </a>

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@milanmajchrak
milanmajchrak merged commit ec23b2b into customer/vsb-tuo Aug 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants