ZCU/Reduce the footer vendor credit to the company name - #1467
Merged
Conversation
The footer credit read "Theme by" stacked above the company name. Drop the wording and leave the name on its own. The i18n key footer.theme.by.message is now unused and removed from en.json5 and cs.json5. Nothing in the credit is translated any more. The anchor itself is untouched, so its rendering — including the *ngVar binding and the [href] — behaves exactly as before. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MatusBeke
added a commit
that referenced
this pull request
Aug 19, 2026
Collaborator
Author
There was a problem hiding this comment.
Pull request overview
This PR simplifies the custom theme footer vendor credit by removing the translated “Theme by” label so only the company name link remains, and cleans up now-unused i18n keys.
Changes:
- Removed the
footer.theme.by.message<p>line from the custom theme footer template. - Removed the unused
footer.theme.by.messagetranslation key fromen.json5andcs.json5.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/themes/custom/app/footer/footer.component.html | Removes the “Theme by” label above the vendor credit link. |
| src/assets/i18n/en.json5 | Drops the now-unused footer.theme.by.message key. |
| src/assets/i18n/cs.json5 | Drops the now-unused footer.theme.by.message key (and its commented duplicate). |
Suppressed comments (1)
src/themes/custom/app/footer/footer.component.html:100
- The vendor credit link always renders even when
companyNameisundefined(e.g., before the config request resolves or ifthemed.by.company.nameis missing), which can leave an empty<a>in the footer (no visible/accessible name, and potentially an emptyhref). Consider guarding the whole credit with*ngIf="(themedByCompanyName$ | async)?.payload?.values[0] as companyName"(or@if) and only rendering the<a>when a non-empty company name is available.
<a class="dtq-sign text-white" *ngVar="(themedByCompanyName$ | async)?.payload?.values[0] as companyName"
[href]="(themedByUrl$ | async)?.payload?.values[0]"
[title]="companyName">
{{ companyName }}
</a>
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Drops the
Theme bywording from the footer's vendor credit and leaves the company name on its own.Part of dataquest-dev/dspace-customers#592, following #1464 (MENDELU) and #1466 (TUL). The wording was picked by the team after voting between several options.
Before / after
Theme byon its own line,+ dataquestunderneath+ dataquestaloneScreenshot below.
What changed
Five deleted lines, nothing added.
src/themes/custom/app/footer/footer.component.html— the<p class="theme-by">above the link is gone. The anchor is untouched: its*ngVarbinding,[href]and[title]behave exactly as before, and the name still comes from the backend propertythemed.by.company.name.en.json5/cs.json5—footer.theme.by.messageremoved, now unused.No new CSS. Neither
.footer-signnor.dtq-signhad any rule of its own on this branch, and the credit keeps the footer's existing link styling.Verification
Built the production image from this branch and rendered it against a local DSpace 7.6 backend with
themed.by.*exposed:+ dataquest.theme-byelementhrefhttps://www.dataquest.sk/dspaceNotes for the reviewer
DSpace software copyright © 2002-2026 LYRASISline above is untouched, so the software copyright stays separate from the vendor credit.customer/zcu-datacarries the same footer markup insrc/app/footer/instead of the theme; it gets the same change in its own PR.🤖 Generated with Claude Code