Skip to content

ZCU/Reduce the footer vendor credit to the company name - #1467

Merged
milanmajchrak merged 1 commit into
customer/zcu-pubfrom
zcu-pub/fe-footer-dataquest-only
Aug 19, 2026
Merged

ZCU/Reduce the footer vendor credit to the company name#1467
milanmajchrak merged 1 commit into
customer/zcu-pubfrom
zcu-pub/fe-footer-dataquest-only

Conversation

@MatusBeke

Copy link
Copy Markdown
Collaborator

Drops the Theme by wording from the footer's vendor credit and leaves the company name on its own.

Part of dataquest-dev/dspace-customers#592, following #1464 (MENDELU) and #1466 (TUL). The wording was picked by the team after voting between several options.

Before / after

before Theme by on its own line, + dataquest underneath
after + dataquest alone

Screenshot below.

What changed

Five deleted lines, nothing added.

src/themes/custom/app/footer/footer.component.html — the <p class="theme-by"> above the link is gone. The anchor is untouched: its *ngVar binding, [href] and [title] behave exactly as before, and the name still comes from the backend property themed.by.company.name.

en.json5 / cs.json5footer.theme.by.message removed, now unused.

No new CSS. Neither .footer-sign nor .dtq-sign had any rule of its own on this branch, and the credit keeps the footer's existing link styling.

Verification

Built the production image from this branch and rendered it against a local DSpace 7.6 backend with themed.by.* exposed:

rendered text + dataquest
.theme-by element not present in the DOM
href https://www.dataquest.sk/dspace
footer height 54px

Notes for the reviewer

  • The DSpace software copyright © 2002-2026 LYRASIS line above is untouched, so the software copyright stays separate from the vendor credit.
  • customer/zcu-data carries the same footer markup in src/app/footer/ instead of the theme; it gets the same change in its own PR.

🤖 Generated with Claude Code

The footer credit read "Theme by" stacked above the company name. Drop the
wording and leave the name on its own.

The i18n key footer.theme.by.message is now unused and removed from
en.json5 and cs.json5. Nothing in the credit is translated any more.

The anchor itself is untouched, so its rendering — including the *ngVar
binding and the [href] — behaves exactly as before.

Refs dataquest-dev/dspace-customers#592

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MatusBeke added a commit that referenced this pull request Aug 19, 2026
@MatusBeke

Copy link
Copy Markdown
Collaborator Author

Footer as it renders with this branch — ZCU theme, production build against a local DSpace 7.6 backend:

ZCU footer with the plain company name

The credit is now just + dataquest, with the name still coming from themed.by.company.name. The DSpace software copyright © 2002-2026 LYRASIS line above it is unchanged.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the custom theme footer vendor credit by removing the translated “Theme by” label so only the company name link remains, and cleans up now-unused i18n keys.

Changes:

  • Removed the footer.theme.by.message <p> line from the custom theme footer template.
  • Removed the unused footer.theme.by.message translation key from en.json5 and cs.json5.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/themes/custom/app/footer/footer.component.html Removes the “Theme by” label above the vendor credit link.
src/assets/i18n/en.json5 Drops the now-unused footer.theme.by.message key.
src/assets/i18n/cs.json5 Drops the now-unused footer.theme.by.message key (and its commented duplicate).
Suppressed comments (1)

src/themes/custom/app/footer/footer.component.html:100

  • The vendor credit link always renders even when companyName is undefined (e.g., before the config request resolves or if themed.by.company.name is missing), which can leave an empty <a> in the footer (no visible/accessible name, and potentially an empty href). Consider guarding the whole credit with *ngIf="(themedByCompanyName$ | async)?.payload?.values[0] as companyName" (or @if) and only rendering the <a> when a non-empty company name is available.
              <a class="dtq-sign text-white" *ngVar="(themedByCompanyName$ | async)?.payload?.values[0] as companyName"
                 [href]="(themedByUrl$ | async)?.payload?.values[0]"
                 [title]="companyName">
                {{ companyName }}
              </a>

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@milanmajchrak
milanmajchrak merged commit c5c4834 into customer/zcu-pub Aug 19, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants