JCU/Reduce the footer vendor credit to the company name - #1470
Conversation
The footer credit read "· Theme by + dataquest" at the end of the copyright line. Drop the wording and leave the company name on its own, so the line reads "DSpace software copyright © 2002-2026 LYRASIS · + dataquest". The wording was hard-coded in the template here, not translated, so there is no i18n key to remove. The @if guard on the company name and the [href] fallback are both untouched. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the application footer’s vendor credit for JCU by removing the hard-coded “Theme by” wording, leaving only the themed company name link when it is available.
Changes:
- Remove the
Theme bytext node from the footer vendor credit span. - Keep the existing
@ifguard around the vendor credit so no empty link is rendered when the backend property is absent.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Review feedback: the credit should stand on its own at the right end of the bar, the way it does on the ZCU and VSB-TUO instances, rather than trailing the copyright sentence. The credit was a <span> inside the copyright <p>, separated by a middot. It is now its own element, a sibling of .content-container, pinned to the right edge of .bottom-footer on md and up. The middot goes with it — it was only there to join two things sharing a line. .bottom-footer gains position: relative as the anchor. No COAR block renders on this instance, so this does not move .notify-enabled, which uses the same absolute-right pattern this rule follows. Below md the bar is a flex column, so the credit simply stacks under the content as the rest of the footer does. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…rline Review feedback on the previous commit: pinning the credit to the right edge of the bar put it flush against the border. Replace the absolute positioning with a plain flex gap, matching how ZCU and VSB-TUO lay theirs out, and widen it to 16rem so the credit reads as separate from the centred block. Dropping absolute positioning also removes the need for position: relative on .bottom-footer, so .notify-enabled keeps its original anchor and the two can no longer end up in the same corner. Also drop text-decoration-underline from the credit link. It made sense while the credit trailed the copyright sentence and needed to look like a link inside running text; standing on its own it read as a button. The anchor is otherwise untouched — href, target, rel and role all stay — and this brings JCU in line with the other customers, none of which underline the credit. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Final state, in 29a2cc6.
Two changes on top of the previous commit: 1. Spacing. Pinning the credit 2. No underline. The link itself is untouched: CI was green on the previous commit ( |
Review feedback: the SCSS comment explaining the credit's layout named two other customer instances. That reference has no business shipping inside a customer's own source tree, and it does not help anyone reading this file. The explanation of what the rule does and why it avoids absolute positioning stays; only the cross-customer reference is gone. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@milanmajchrak fixed in 83a9011 — the other customers are out of the comment. // Vendor credit stands on its own to the right of the centred copyright
- // block, as it does on the ZCU and VSB-TUO instances. A plain flex item
- // with a wide gap rather than absolute positioning, so it never overlaps
- // the .notify-enabled block that pins itself bottom-right.
+ // block. A plain flex item with a wide gap rather than absolute
+ // positioning, so it never overlaps the .notify-enabled block that pins
+ // itself bottom-right.Fair point — that reference has no business shipping inside a customer's own source tree. The part explaining what the rule does and why it avoids absolute positioning stays, since that is the bit a future reader actually needs. Checked the rest of the diff for the same problem: no other customer name appears anywhere in it. One thing I cannot clean up the same way: the commit message on 29a2cc6 also mentions both instances, and that lands in |
Drops the
Theme bywording from the footer's vendor credit and leaves the company name on its own. Last of the rollout.Part of dataquest-dev/dspace-customers#592, following #1464 (MENDELU), #1466 (TUL), #1467 and #1468 (ZCU) and #1469 (VSB-TUO).
Before / after
On this branch the credit sits inline at the end of the copyright line rather than in its own column:
DSpace software copyright © 2002-2026 LYRASIS · Theme by + dataquestDSpace software copyright © 2002-2026 LYRASIS · + dataquestScreenshot below.
What changed
One line, in
src/app/footer/footer.component.html:The wording was hard-coded here rather than translated, so there is no i18n key to remove — unlike MENDELU, ZCU and VSB-TUO. The
@ifguard on the company name and the|| '#'fallback on[href]are both untouched, as is the separator and the link styling.No CSS is added or changed.
Verification
The screenshot below is the live JCU instance on dev-6 with the
Theme bytext node removed — the same text this PR deletes. Colours, layout and data are the instance's own.A production build of this branch is still running as I open this; I will confirm the rendered markup underneath once it finishes. The change is a single text deletion inside an existing element, so there is nothing in it that can move layout or styling.
🤖 Generated with Claude Code