fix(examples): repair ik_speed.py after fknm/frne refactor and API renames#561
Open
petercorke wants to merge 1 commit into
Open
fix(examples): repair ik_speed.py after fknm/frne refactor and API renames#561petercorke wants to merge 1 commit into
petercorke wants to merge 1 commit into
Conversation
…names ik_speed.py predated both the fknm/frne module move (import fknm -> a module path that no longer exists) and the IK solver API rename (ik_lm_chan/ik_nr/ik_gn -> ik_LM(method=...)/ik_NR/ik_GN with renamed kwargs), so it hadn't actually run in some time. Rewrite against the current API, drop stale unused imports, and add modern type hints. Port cpu_info() (added earlier for rne_speed.py) into a shared examples/_cpu_info.py now that ik_speed.py is a second call site. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 142 142
Lines 13788 13788
=====================================
Misses 13788 13788 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/ik_speed.pyhad gone stale:import fknmno longer resolves since the fknm/frne refactor (merged to main 2026-07-03), and the IK solver calls used a since-renamed API (ik_lm_chan/ik_nr/ik_gn→ik_LM(method=...)/ik_NR/ik_GN, with renamed kwargs).cpu_info()helper (added earlier forrne_speed.py) out into a sharedexamples/_cpu_info.py, now thatik_speed.pyis a second call site.tech-debt.md's entry to reflect the fix.Test plan
python examples/ik_speed.pyruns end-to-end, prints a valid timing table for NR/GN/LM(chan/wampler/sugihara)python examples/rne_speed.pystill runs after the shared_cpu_infoextraction🤖 Generated with Claude Code