[ci] Drive matrix jobs from typed plans - #3591
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G9897ad03a6cbd7a3472a2b8184fd6ae8 #3591 +/- ##
====================================================================
Coverage ? 91.85%
====================================================================
Files ? 20
Lines ? 6093
Branches ? 0
====================================================================
Hits ? 5597
Misses ? 496
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f90984d to
4f0c3e7
Compare
1c25593 to
1632fd7
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
46de7c3 to
50f0868
Compare
4f0c3e7 to
2a757e8
Compare
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
78a1d2e to
e8060ec
Compare
1cec11e to
bf776ff
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
bf776ff to
ce1213f
Compare
e8060ec to
2a7826a
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2a7826a to
8e2bc56
Compare
ce1213f to
9211778
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
9211778 to
fdf9df2
Compare
8824884 to
b37f87b
Compare
fdf9df2 to
84816d5
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
84816d5 to
358e200
Compare
b37f87b to
2c11865
Compare
358e200 to
c131b7f
Compare
2c11865 to
e77f592
Compare
The ordinary workflow still maintained hundreds of lines of matrix axes, exclusions, feature shell fragments, and command conditions beside the checked Rust policy. Either representation could drift while the other continued to look valid. Make the planner outputs authoritative for build and Miri fan-out. Each job passes only quoted cell selectors to cargo-zerocopy, which replans the event, resolves all command behavior from checked inputs, and rejects an unknown or excluded cell before starting work. Retire the old YAML-to-manifest toolchain checker in the same change which removes its handwritten matrix input. The preceding commit proves the replacement two-way inventory invariant, so this switch has no under-checked boundary and cannot fail by parsing a fromJSON expression. Keep runner, image, artifact, permission, and third-party action choices visible in Actions YAML. Preserve the literal semver action as the one workflow-owned exception, and correctly forward the pull request head SHA used by its existing commit-message skip contract. This intentionally preserves coverage: pull requests still select 60 build and zero Miri cells; full events select 182 build and 64 Miri cells. Removing the retired hosted checker also saves one runner startup and yq installation, plus one duplicate local pre-push process. Tests: ci/check_actions.sh Tests: ci/check_job_dependencies.sh Tests: ci/check_tools.sh Tests: githooks/test_pre_push.py Tests: ci/check_fmt.sh Tests: cargo clippy -p zc --all-targets --offline -- -D warnings *Authored by an agent, posting via joshlf's account* gherrit-pr-id: Gquoamyb32c2czjlzvvkel27kkqeg2tid
c131b7f to
a309bd0
Compare
e77f592 to
5545348
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
The ordinary workflow still maintained hundreds of lines of matrix
axes, exclusions, feature shell fragments, and command conditions beside
the checked Rust policy. Either representation could drift while the
other continued to look valid.
Make the planner outputs authoritative for build and Miri fan-out. Each
job passes only quoted cell selectors to cargo-zerocopy, which replans
the event, resolves all command behavior from checked inputs, and
rejects an unknown or excluded cell before starting work.
Retire the old YAML-to-manifest toolchain checker in the same change
which removes its handwritten matrix input. The preceding commit proves
the replacement two-way inventory invariant, so this switch has no
under-checked boundary and cannot fail by parsing a fromJSON expression.
Keep runner, image, artifact, permission, and third-party action choices
visible in Actions YAML. Preserve the literal semver action as the one
workflow-owned exception, and correctly forward the pull request head
SHA used by its existing commit-message skip contract.
This intentionally preserves coverage: pull requests still select 60
build and zero Miri cells; full events select 182 build and 64 Miri
cells. Removing the retired hosted checker also saves one runner startup
and yq installation, plus one duplicate local pre-push process.
Tests: ci/check_actions.sh
Tests: ci/check_job_dependencies.sh
Tests: ci/check_tools.sh
Tests: githooks/test_pre_push.py
Tests: ci/check_fmt.sh
Tests: cargo clippy -p zc --all-targets --offline -- -D warnings
Authored by an agent, posting via joshlf's account
Latest Update: v29 — Compare vs v28
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gquoamyb32c2czjlzvvkel27kkqeg2tid && git checkout -b pr-Gquoamyb32c2czjlzvvkel27kkqeg2tid FETCH_HEADCheckout
git fetch origin refs/heads/Gquoamyb32c2czjlzvvkel27kkqeg2tid && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gquoamyb32c2czjlzvvkel27kkqeg2tid && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.