[ci] Define a typed CI coverage policy - #3575
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G2no4jjfqasubxit6mn7xvdcyd3ko5ji3 #3575 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6093 6093
==================================================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4aa8517069
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b782d7c to
146dbe6
Compare
4aa8517 to
0c5a889
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
146dbe6 to
f3da816
Compare
0c5a889 to
057e851
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 057e851aee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f3da816 to
f25c5da
Compare
057e851 to
0be1058
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head. Treat earlier reviews of older commits as stale. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0be1058023
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0be1058 to
dabba7d
Compare
f25c5da to
540594a
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dabba7debd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dabba7d to
7710b76
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
540594a to
8c1814e
Compare
7710b76 to
19ffc49
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19ffc4902e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
19ffc49 to
ce60396
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
06e6ce7 to
8623ac9
Compare
ce60396 to
4ae5925
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ae59253eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Describe ordinary build, Miri, and semver coverage in a versioned TOML file which the repository-owned zc tool parses into typed data. Keep workflow permissions, secrets, runners, action references, and publication in the hand-written workflows so generated data cannot grant privileges. Reject unknown fields, unsafe paths, duplicate or dangling identifiers, overlapping work, incomplete target coverage, stale waivers, and matrix limits above GitHub's bounds. Require semver checks to use the semantic stable-aggregate profile and the pinned-stable toolchain source; policy names may change without weakening either constraint. Report independent semantic errors together and preserve deterministic ordering throughout the validated model. Preflight selected Cartesian products with saturating arithmetic before allocating their cells. Count the complete required Miri universe without materializing it. Validated selected cells are a distinct subset of that universe, so equal cardinality proves complete coverage. A malformed policy with a large missing product receives one bounded summary instead of one allocation and diagnostic per missing cell. Bound target and target-set declarations, aggregate resolved memberships, and identifier bytes before cloning target sets. If a plan is too large to materialize, continue scalar, reference, unused-set, and Miri-eligibility validation while skipping only pairwise checks which need those cells. An invalid empty target set also skips cell-dependent package/profile products after its own diagnostic, so multiplying by zero cannot bypass the allocation and diagnostic bound. This keeps derived work within hard limits without discarding independent errors. This commit only establishes and tests the policy boundary. Existing workflows remain authoritative until later commits add inventory, planning, baseline comparison, and shadow-mode integration. Tests: CARGO_NET_OFFLINE=true ./ci/check_tools.sh Tests: ./ci/check_fmt.sh *Authored by an agent, posting via joshlf's account* gherrit-pr-id: Gqofuqcjxqt64bw7di2snqyunualoi3ht
8623ac9 to
41eb8c4
Compare
4ae5925 to
0617cce
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Describe ordinary build, Miri, and semver coverage in a versioned TOML
file which the repository-owned zc tool parses into typed data. Keep
workflow permissions, secrets, runners, action references, and
publication in the hand-written workflows so generated data cannot
grant privileges.
Reject unknown fields, unsafe paths, duplicate or dangling identifiers,
overlapping work, incomplete target coverage, stale waivers, and matrix
limits above GitHub's bounds. Require semver checks to use the semantic
stable-aggregate profile and the pinned-stable toolchain source; policy
names may change without weakening either constraint. Report independent
semantic errors together and preserve deterministic ordering throughout
the validated model.
Preflight selected Cartesian products with saturating arithmetic before
allocating their cells. Count the complete required Miri universe
without materializing it. Validated selected cells are a distinct subset
of that universe, so equal cardinality proves complete coverage. A
malformed policy with a large missing product receives one bounded
summary instead of one allocation and diagnostic per missing cell.
Bound target and target-set declarations, aggregate resolved
memberships, and identifier bytes before cloning target sets. If a plan
is too large to materialize, continue scalar, reference, unused-set, and
Miri-eligibility validation while skipping only pairwise checks which
need those cells. An invalid empty target set also skips cell-dependent
package/profile products after its own diagnostic, so multiplying by
zero cannot bypass the allocation and diagnostic bound. This keeps
derived work within hard limits without discarding independent errors.
This commit only establishes and tests the policy boundary. Existing
workflows remain authoritative until later commits add inventory,
planning, baseline comparison, and shadow-mode integration.
Tests: CARGO_NET_OFFLINE=true ./ci/check_tools.sh
Tests: ./ci/check_fmt.sh
Authored by an agent, posting via joshlf's account
Latest Update: v29 — Compare vs v28
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gqofuqcjxqt64bw7di2snqyunualoi3ht && git checkout -b pr-Gqofuqcjxqt64bw7di2snqyunualoi3ht FETCH_HEADCheckout
git fetch origin refs/heads/Gqofuqcjxqt64bw7di2snqyunualoi3ht && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gqofuqcjxqt64bw7di2snqyunualoi3ht && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.