[ci] Read frozen CI baselines strictly - #3577
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Ghrxpfppzzenc5ecwz3u273gd42e4psk7 #3577 +/- ##
====================================================================
Coverage ? 91.85%
====================================================================
Files ? 20
Lines ? 6093
Branches ? 0
====================================================================
Hits ? 5597
Misses ? 496
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2fdec85 to
4864e15
Compare
ca89a5d to
1b5b56e
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
4864e15 to
b49d72d
Compare
1b5b56e to
67fc58e
Compare
453c9c9 to
cc02374
Compare
8da94d7 to
e19d827
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e19d827d4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cc02374 to
41ece9e
Compare
e19d827 to
5488531
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
5488531 to
da7ad19
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
da7ad19 to
d6bc5ea
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
6ea01e9 to
e5ca1fb
Compare
d6bc5ea to
82ce4ba
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
82ce4ba to
c84c440
Compare
e5ca1fb to
7f75458
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c84c44097a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c84c440 to
fec9a20
Compare
Add typed, data-only readers for the eight files which record legacy CI
behavior. Require exact headers, field counts, row order, identifiers,
paths, counts, hashes, command forms, action references, and canonical
JSON. Reject invalid UTF-8, control characters, duplicate rows, and
manifest counts which disagree with the parsed data.
Keep parsed fields private and expose validated constructors so future
plans cannot bypass the same invariants when comparing exact sets.
Reparse public string-bearing enum values and compare the resulting
canonical variant, preventing `WorkingDirectory::Relative(".")` from
entering a record as an alternate spelling of the repository root.
Report missing and extra work separately and in deterministic order.
This reader deliberately does not parse workflow YAML or regenerate the
baseline. The checked-in files remain independent review evidence from
the old workflow rather than an expectation produced by the new planner.
Tests: standalone warning-free compilation; baseline mutation tests.
*Authored by an agent, posting via joshlf's account*
gherrit-pr-id: Gt4itljw3xh6tci2mjqj4z245i6pwle2i
7f75458 to
d5d5a26
Compare
fec9a20 to
0adf985
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Add typed, data-only readers for the eight files which record legacy CI
behavior. Require exact headers, field counts, row order, identifiers,
paths, counts, hashes, command forms, action references, and canonical
JSON. Reject invalid UTF-8, control characters, duplicate rows, and
manifest counts which disagree with the parsed data.
Keep parsed fields private and expose validated constructors so future
plans cannot bypass the same invariants when comparing exact sets.
Reparse public string-bearing enum values and compare the resulting
canonical variant, preventing
WorkingDirectory::Relative(".")fromentering a record as an alternate spelling of the repository root.
Report missing and extra work separately and in deterministic order.
This reader deliberately does not parse workflow YAML or regenerate the
baseline. The checked-in files remain independent review evidence from
the old workflow rather than an expectation produced by the new planner.
Tests: standalone warning-free compilation; baseline mutation tests.
Authored by an agent, posting via joshlf's account
Latest Update: v29 — Compare vs v28
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gt4itljw3xh6tci2mjqj4z245i6pwle2i && git checkout -b pr-Gt4itljw3xh6tci2mjqj4z245i6pwle2i FETCH_HEADCheckout
git fetch origin refs/heads/Gt4itljw3xh6tci2mjqj4z245i6pwle2i && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gt4itljw3xh6tci2mjqj4z245i6pwle2i && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.