[ci] Guard consolidated build and test jobs - #3561
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G386fde8c9c2d7c96a9f67f5f5a0f5a64 #3561 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6093 6093
==================================================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Authored by Codex, posting via joshlf's account @codex review Please review the current exact head after the stack reorder and recovery. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
f7e334e to
3d2f255
Compare
4be51ba to
0caf293
Compare
|
Authored by Codex, posting via joshlf's account @codex review Please review the current exact head after addressing the prior feedback. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3d2f255 to
5b71dd8
Compare
0caf293 to
56384c5
Compare
joshlf
changed the title
56384c5 to
74eb8bf
Compare
joshlf
changed the title
|
Authored by an agent, posting via joshlf's account @jswrenn, this reconstructs #3506 at the bottom of the current stack. The commit message now describes the affected jobs directly, explains the Cargo profile assumption and safeguards in plain language, and retains the measured latency and runner-time results. Would you please re-review current head 74eb8bf? |
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74eb8bf9f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
74eb8bf to
e990345
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Consolidate an ordinary native cell only when its audited feature selection enables an integration target. Otherwise retain a separate build, since unit tests do not prove the normal library artifact. Always retain the build for proc macros: Cargo 1.56 does not emit their dev artifact from `cargo test`, and `zerocopy-derive`'s dev-only `syn/visit` feature otherwise masks its production `syn/full` graph. An independent current-state audit checks the exact required builds without rewriting immutable historical evidence. Reject a root `[profile.test]`, any CI `CARGO_PROFILE_TEST_*` override, and a non-unwind dev panic strategy. Keep other dev settings supported, while rejecting Cargo configuration and profile selectors that would change consolidated jobs. Run a centralized `cargo tree` smoke test in `check_tools` as a review reminder for dev-dependency feature unification, while keeping its documented approximation explicit. The original 44-cell consolidation reduced non-Anneal PR wall time from 5:32 to 4:04 against its then-parent. Across two comparable baselines, the average reduction was 73 seconds (23%), while total runner time across the 60-job matrix fell by 30:03 (17.3%). This change preserves consolidation in 38 of 44 native cells; the measured figures are therefore an upper bound until the six short proc-macro builds are remeasured. *Authored by an agent, posting via joshlf's account* gherrit-pr-id: G4ad937d415e180e0db2a85c15fbe30d3
e990345 to
38b706d
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Consolidate an ordinary native cell only when its audited feature
selection enables an integration target. Otherwise retain a separate
build, since unit tests do not prove the normal library artifact.
Always retain the build for proc macros: Cargo 1.56 does not emit their
dev artifact from
cargo test, andzerocopy-derive's dev-onlysyn/visitfeature otherwise masks its productionsyn/fullgraph.An independent current-state audit checks the exact required builds
without rewriting immutable historical evidence.
Reject a root
[profile.test], any CICARGO_PROFILE_TEST_*override,and a non-unwind dev panic strategy. Keep other dev settings supported,
while rejecting Cargo configuration and profile selectors that would
change consolidated jobs. Run a centralized
cargo treesmoke test incheck_toolsas a review reminder for dev-dependency featureunification, while keeping its documented approximation explicit.
The original 44-cell consolidation reduced non-Anneal PR wall time
from 5:32 to 4:04 against its then-parent. Across two comparable
baselines, the average reduction was 73 seconds (23%), while total
runner time across the 60-job matrix fell by 30:03 (17.3%). This
change preserves consolidation in 38 of 44 native cells; the measured
figures are therefore an upper bound until the six short proc-macro
builds are remeasured.
Authored by an agent, posting via joshlf's account
Latest Update: v7 — Compare vs v6
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G4ad937d415e180e0db2a85c15fbe30d3 && git checkout -b pr-G4ad937d415e180e0db2a85c15fbe30d3 FETCH_HEADCheckout
git fetch origin refs/heads/G4ad937d415e180e0db2a85c15fbe30d3 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G4ad937d415e180e0db2a85c15fbe30d3 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.