Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Decision 5 (C65): a file can be marked viewed. The mark is kept on this Mac per account and belongs to one revision; a new head or base shows none. Marking folds the file; the tree and a count show progress. Nothing is read from or sent to GitHub. Decision 6 (C07): the unavailable new-tab button is removed. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Measured on real pull requests, every control was reachable with Tab but only through 34 to 124 presses between areas, and 147 arrows to the last of 151 files. F6 and Shift+F6 now move between the inbox, the pane tabs, the pane and the file list; [ and ] move to the previous and next file. Keys typed in a text field stay text. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Measured on 10 real pull requests, opening one took 2 to 5 s to its title and 6 to 7 s to its checks. Three causes are addressed: - Reads for an opened pull request go ahead of inbox lookups that have not started; a running read is never interrupted. - The overview uses resolve's read of the pull request once, within 2 s, under the same account, and only if nothing newer read it. - The merge base and the file page are read together between the two guarding reads. Checks and activity keep their order: a failed first read still costs GitHub nothing further. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ox rows GitHub comment bodies often carry HTML (details, sup, img, links). The overview showed the tags as raw text. Known tags outside code are now dropped, and an image becomes "Image: alt". Inbox rows show repo #number. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… first benchmark fixes (#319) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
BunsDev
left a comment
There was a problem hiding this comment.
Read-only review of the local Viewed persistence path; one reproduced recovery issue below.
| const next = paths.length ? [...rest, [id(key), { baseSha: revision.baseSha, headSha: revision.headSha, paths } satisfies Entry]] : rest; | ||
| try { | ||
| storage.setItem(VIEWED_KEY, JSON.stringify({ ...read(storage), [key.account]: Object.fromEntries(next) })); | ||
| } catch { /* A full or blocked store keeps the mark for this session only. */ } |
There was a problem hiding this comment.
[P2] Preserve session marks when local storage rejects writes
When localStorage.setItem throws (for example, quota exhaustion), this catch returns the new paths to React, but the next toggle reconstructs current from storage rather than that session state. I reproduced this against exact head 7c8f365 with getItem returning null and setItem throwing: marking src/a.ts returns ["src/a.ts"], then marking src/b.ts returns only ["src/b.ts"]. Thus marking a second file visibly clears the first mark even without reloading; the stated session-only fallback does not hold. With an existing persisted mark, unmarking it can similarly be undone by the next toggle. Please retain an account/repository/PR/revision-scoped in-memory fallback or pass the current React state through the update, and add a blocked/full-storage regression covering mark A, mark B, unmark A and another toggle. No owner worktree edits or live GitHub writes were used in the reproduction.
CodeQL flagged the tag pattern (polynomial backtracking on an unclosed tag) and the comment strip (one replace can leave a new opener). A character scanner replaces both; hostile inputs are timed in the test. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage-agent
View coverage of the 4 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
The bracket key focuses its file on the next animation frame. The keyboard test went on to focus the filter and type at once, so on a slow runner that focus arrived mid-typing and the filter kept only the first character. This failed the merge queue run for #506. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
First fixes from the real-use benchmark on ten pull requests of this repository (#319), plus Val's decisions 5 and 6 of 2026-11-04.
resolvehands its read tooverviewonce; the merge base and the first file page are read in parallel. Measured on the real repository: find about 2.0 s (was 3.8 s), checks ready about 4.8 s (was 6.6 s).repo #number.[and]move between files in Changes.Not in this PR: review comments made on diff lines are still not shown, and the benchmark has not been re-run on this build.
Testing
pnpm build && pnpm test: 0 failures.🤖 Generated with Claude Code