Skip to content

Code Review: first pass at the new look - #511

Draft
BunsDev wants to merge 8 commits into
mainfrom
cr-look
Draft

BunsDev wants to merge 8 commits into
mainfrom
cr-look

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Draft. A first pass at the Code Review look Val asked for from screenshots. Stacked on #506.

What changes

  • A larger, lighter title and a single quiet meta line.
  • Each check has a status glyph (passed, failed, running) in place of its "· success" text.
  • Sidebar sections are divided by hairlines; header buttons are pills.
  • Inbox rows show the author's initial.

Not in this pass

  • Summary and Changes as a switch inside the pane (the tabs are still in the title bar; moving them changes the keyboard-navigation tests, so it waits for Val's call).
  • The status card, Comments in the sidebar, the floating Ask composer, real avatars, and state glyphs on inbox rows.

Testing

  • pnpm test: 0 failures. All Code Review e2e specs: 107 passed and one timing flake in code-review-actions.spec.ts:247 under load; it passes alone and the spec passes 15/15 on a rerun.

🤖 Generated with Claude Code

BunsDev and others added 7 commits November 12, 2026 03:30
Decision 5 (C65): a file can be marked viewed. The mark is kept on this
Mac per account and belongs to one revision; a new head or base shows
none. Marking folds the file; the tree and a count show progress.
Nothing is read from or sent to GitHub.

Decision 6 (C07): the unavailable new-tab button is removed.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Measured on real pull requests, every control was reachable with Tab but
only through 34 to 124 presses between areas, and 147 arrows to the last
of 151 files. F6 and Shift+F6 now move between the inbox, the pane tabs,
the pane and the file list; [ and ] move to the previous and next file.
Keys typed in a text field stay text.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Measured on 10 real pull requests, opening one took 2 to 5 s to its
title and 6 to 7 s to its checks. Three causes are addressed:

- Reads for an opened pull request go ahead of inbox lookups that have
  not started; a running read is never interrupted.
- The overview uses resolve's read of the pull request once, within 2 s,
  under the same account, and only if nothing newer read it.
- The merge base and the file page are read together between the two
  guarding reads.

Checks and activity keep their order: a failed first read still costs
GitHub nothing further.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ox rows

GitHub comment bodies often carry HTML (details, sup, img, links). The overview showed the tags as raw text.
Known tags outside code are now dropped, and an image becomes "Image: alt". Inbox rows show repo #number.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… first benchmark fixes (#319)

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
CodeQL flagged the tag pattern (polynomial backtracking on an unclosed tag) and the comment strip
(one replace can leave a new opener). A character scanner replaces both; hostile inputs are timed in the test.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
A larger, lighter title and one quiet meta line; a status glyph on each check; hairline sections in the
sidebar; pill buttons in the header; an author initial on inbox rows. Sizes the layout tests depend on
(header height, sidebar width) are unchanged.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 12, 2026 4:01pm UTC
modex-app Building Building Preview Nov 12, 2026 4:01pm UTC

Request Review

@github-code-quality

github-code-quality Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

cr-viewed 5a580d4 cr-look d0196d9 +/-
66% 66% 0%
View coverage of the 10 most impacted files.
File cr-viewed 5a580d4 cr-look d0196d9 +/-
apps/desktop/sr.../routing/jev.ts 96% 90% -6%
apps/desktop/sr...uting/policy.ts 100% 99% -1%
apps/desktop/sr...ngine/runner.ts 98% 98% 0%
apps/store-desk...rc/main/demo.ts 95% 95% 0%
apps/desktop/sr...kends/claude.ts 98% 98% 0%
apps/desktop/sr...ckends/codex.ts 97% 97% 0%
apps/desktop/sr...read-service.ts 98% 99% +1%
apps/desktop/sr...-review/keys.ts 0% 67% +67%
apps/desktop/sr.../remote-text.ts 0% 98% +98%
apps/desktop/sr...eview/viewed.ts 0% 100% +100%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 12, 2026 16:45 UTC

The overview gains a card that says what was read: the standing review
verdicts from loaded activity and the check tally for the current head.
The meta line shows the author's initial and a relative age, and draft
pull requests carry a dashed mark in the inbox.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
Preview – modex — d0196d99 Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant