Skip to content

Show Code Review by default (v0.5.0 candidate, waits for Val) - #515

Draft
BunsDev wants to merge 9 commits into
cr-inline-commentsfrom
cr-default-on
Draft

BunsDev wants to merge 9 commits into
cr-inline-commentsfrom
cr-default-on

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Draft. This waits for Val and is not for the merge queue.

Makes Code Review visible by default in built and development apps.

  • DEFAULT_LAYOUT.codeReview is true. Settings → General → "Show Code Review in the rail" still hides it, a saved choice to hide it is kept, and the old modex.codeReview switch is still migrated.
  • The Store build and the browser demo pass codeReviewEnabled={false} and are unchanged.
  • The enablement e2e and the layout unit tests assert the new default and the rollback.
  • Val's session doc is reduced to what only Val can do: the VoiceOver pass, using the candidate on real reviews, the CR-7 canary (no repository named yet), four items listed for approval, and the default-on and release call.

The code and tests come from the uncommitted work in the v0.4.2 recovery worktree. Its README and v0.4.2 release-review edits are not included; they belong to that release's record.

Stacked on #513 (inline review comments), which is stacked on #506, so the candidate carries the real-use fixes. main is merged in.

The one full run (pnpm build && pnpm test && pnpm test:e2e, no reruns) on 683ab6e is recorded in docs/reviews/2026-11-04-v0.5.0-candidate.md:

  • Build passed. Unit tests: 2,579, 2,543 passed, 36 skipped, 0 failed.
  • Desktop e2e: 534 tests, 522 passed, 11 skipped, 1 failed. The failing test was this PR's own enablement test: a check added with the change required that no provider CLI started at all, and the app's own version checks had. Everything about Code Review in that test passed.
  • The following commit (f817f41) makes that check ask for no model turn. The spec then passed alone (3 of 3). The site and browser-demo e2e, which the stopped command never reached, were run once each and passed (8 and 4). No second full run was made.

🤖 Generated with Claude Code

BunsDev and others added 8 commits November 12, 2026 09:12
…es (#503)

* test(local-models): preserve drafts and selection across metadata races

* docs(local-models): record preservation qualification
* feat: conserve low coding allowance and credits in Auto

* fix: enforce quota admission on retries and selected routes

* docs: record credit conservation qualification and limits

* fix: admit every automatic credit replacement and preserve rotation

* docs: record integrated credit conservation qualification
* feat(web, site): browser demo for app.modex.codes and a graphite landing page

apps/web puts the desktop renderer in a browser on the Store edition's
in-memory demo workspace. It runs no model, CLI, shell or file operation;
its CSP and a browser test keep every request on its own origin. A banner
says what is simulated and links to the Mac download. StoreDemo takes
optional copy so the web edition points to the Mac app; the Store
edition's defaults are unchanged.

apps/site now wears the app's graphite appearance. The hero is the app's
welcome workspace (logo tile, four work modes, shortcuts), sections reuse
the app's card surfaces and icons, and the workflow captures were retaken
from the current interface. Manrope is removed for the app's system stack.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>

* fix(site): keep the hero's in-page link on its own row and space link arrows

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
#504 added apps/web to the root build, so every worktree that builds now
holds apps/web/dist (and test-results after its browser tests). The
generated-data allowlist did not name apps/web, so `remove` and the daily
prune kept such worktrees as unknown ignored data.

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
The job hit its 45-minute limit three times in a row on 2026-11-12 with no failing test: on PR #508
(504 of 531 e2e tests passed when it was cut off) and in the merge queue for #506 and #509, which
dropped #506 from the queue. The three green queue runs before them took 29, 44 and 45 minutes.

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
DEFAULT_LAYOUT.codeReview is true in built and development apps. An explicit
saved choice to hide it is kept, as is the legacy modex.codeReview switch's
migration. The Store build and the browser demo pass codeReviewEnabled={false}
and are unchanged.

From the uncommitted work in the v0.4.2 recovery worktree (code and tests only).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 12, 2026 4:27pm UTC
modex-app Building Building Preview Nov 12, 2026 4:27pm UTC

Request Review

The one full run failed one test: the new check required that no provider CLI
started at all, and the app's own version checks had. It now requires that no
model turn started. The run is recorded as it happened.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

cr-inline-comments 3691bc5 cr-default-on f817f41 +/-
66% 66% 0%
View coverage of the 6 most impacted files.
File cr-inline-comments 3691bc5 cr-default-on f817f41 +/-
apps/desktop/sr...eview/github.ts 99% 99% 0%
apps/desktop/sr.../code-review.ts 100% 100% 0%
apps/desktop/sr...read-service.ts 98% 99% +1%
apps/desktop/sr...-review/keys.ts 0% 67% +67%
apps/desktop/sr.../remote-text.ts 0% 98% +98%
apps/desktop/sr...eview/viewed.ts 0% 100% +100%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

This branch was successfully deployed

1 active deployment
Preview – modex — f817f410 Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant