Repository navigation
Conversation
Decision 5 (C65): a file can be marked viewed. The mark is kept on this Mac per account and belongs to one revision; a new head or base shows none. Marking folds the file; the tree and a count show progress. Nothing is read from or sent to GitHub. Decision 6 (C07): the unavailable new-tab button is removed. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Measured on real pull requests, every control was reachable with Tab but only through 34 to 124 presses between areas, and 147 arrows to the last of 151 files. F6 and Shift+F6 now move between the inbox, the pane tabs, the pane and the file list; [ and ] move to the previous and next file. Keys typed in a text field stay text. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Measured on 10 real pull requests, opening one took 2 to 5 s to its title and 6 to 7 s to its checks. Three causes are addressed: - Reads for an opened pull request go ahead of inbox lookups that have not started; a running read is never interrupted. - The overview uses resolve's read of the pull request once, within 2 s, under the same account, and only if nothing newer read it. - The merge base and the file page are read together between the two guarding reads. Checks and activity keep their order: a failed first read still costs GitHub nothing further. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ox rows GitHub comment bodies often carry HTML (details, sup, img, links). The overview showed the tags as raw text. Known tags outside code are now dropped, and an image becomes "Image: alt". Inbox rows show repo #number. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… first benchmark fixes (#319) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
CodeQL flagged the tag pattern (polynomial backtracking on an unclosed tag) and the comment strip (one replace can leave a new opener). A character scanner replaces both; hostile inputs are timed in the test. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The real-use benchmark found that comments on lines of the diff were counted but shown nowhere (F3).
The first activity page now also reads pulls/{n}/comments (a GET, first 100) and lists each with its
file, line and whether it is a reply. A failed read leaves the timeline usable and marks the page
partial. Whether a thread is resolved is not read; GitHub gives that only over GraphQL.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The overview always receives the write service, so the plain Comment,
Edit pull request and Request reviewers fallbacks ("This action isn't
connected yet.") were unreachable. The service is now required.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The bracket key focuses its file on the next animation frame. The keyboard test went on to focus the filter and type at once, so on a slow runner that focus arrived mid-typing and the filter kept only the first character. This failed the merge queue run for #506. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage-agent
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
# Conflicts: # apps/desktop/src/main/engine/code-review/read-service.ts # apps/desktop/src/renderer/code-review/PrOverview.tsx # apps/desktop/test/code-review-read-service.test.ts # docs/status.md
|
Read-only delivery check at Current main |
|
Read-only follow-up at |
|
The source at The actual protected checkout passed 2,587 units with 36 skips, 533 desktop E2E cases with 14 opt-in skips, eight site cases and four web cases, with no retry annotations. Both protected artifacts passed digest and ZIP-integrity checks. #520 also retains the first iPhone job cancellation and the corrected source’s complete iPhone qualification; the merge-group iPhone job itself was skipped. Its reviews corrected the three Minor feature findings and separately qualified the CI-only budget correction. The authenticated real-PR benchmark now observes the real comments, reply and unavailable-current-line labels on #514/#506 through production reads. Resolved-thread state, inline placement and comments beyond the first 100 remain tracked limitations; parent issue acceptance, real-provider review, live-write, human/device and activation gates remain separate. The original branch and checkout are preserved for their existing owner. |
Pull request was closed
Stacked on #506. From the real-use benchmark (#319): comments made on lines of the diff were counted in the summary but shown nowhere (finding F3).
What changes
repos/{o}/{r}/pulls/{n}/comments(a GET, the first 100). Each comment is listed in Activity with its file, line and whether it is a reply, and appears under the Comments filter.Not in this change
Testing
code-review-read-service.test.ts; all three fail when the comments are left out of the result (mutation run), and pass when restored.code-review-regressions.spec.tswith a hostile comment body.pnpm test: 0 failures. Code Review e2e: 108 passed, 1 failed (code-review-diff.spec.ts:108, a keyboard test this change does not touch); it passed 3 of 3 when rerun alone while the machine was less loaded.🤖 Generated with Claude Code