Skip to content

Code Review: list comments made on diff lines in Activity (#319) - #513

Closed
BunsDev wants to merge 11 commits into
mainfrom
cr-inline-comments
Closed

BunsDev wants to merge 11 commits into
mainfrom
cr-inline-comments

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Stacked on #506. From the real-use benchmark (#319): comments made on lines of the diff were counted in the summary but shown nowhere (finding F3).

What changes

  • The first activity page also reads repos/{o}/{r}/pulls/{n}/comments (a GET, the first 100). Each comment is listed in Activity with its file, line and whether it is a reply, and appears under the Comments filter.
  • A refused or malformed read leaves the timeline usable and marks the page partial; more than 100 is reported as capped.
  • Comment text goes through the same inert Markdown path as other comments.

Not in this change

  • Whether a thread is resolved. GitHub gives that only over GraphQL, and the read service uses REST only; that is Val's call.
  • Showing the comments beside their line in Changes.
  • Pages after the first 100 comments.

Testing

  • Three unit tests in code-review-read-service.test.ts; all three fail when the comments are left out of the result (mutation run), and pass when restored.
  • One e2e test in code-review-regressions.spec.ts with a hostile comment body.
  • pnpm test: 0 failures. Code Review e2e: 108 passed, 1 failed (code-review-diff.spec.ts:108, a keyboard test this change does not touch); it passed 3 of 3 when rerun alone while the machine was less loaded.

🤖 Generated with Claude Code

BunsDev and others added 7 commits November 12, 2026 03:30
Decision 5 (C65): a file can be marked viewed. The mark is kept on this
Mac per account and belongs to one revision; a new head or base shows
none. Marking folds the file; the tree and a count show progress.
Nothing is read from or sent to GitHub.

Decision 6 (C07): the unavailable new-tab button is removed.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Measured on real pull requests, every control was reachable with Tab but
only through 34 to 124 presses between areas, and 147 arrows to the last
of 151 files. F6 and Shift+F6 now move between the inbox, the pane tabs,
the pane and the file list; [ and ] move to the previous and next file.
Keys typed in a text field stay text.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Measured on 10 real pull requests, opening one took 2 to 5 s to its
title and 6 to 7 s to its checks. Three causes are addressed:

- Reads for an opened pull request go ahead of inbox lookups that have
  not started; a running read is never interrupted.
- The overview uses resolve's read of the pull request once, within 2 s,
  under the same account, and only if nothing newer read it.
- The merge base and the file page are read together between the two
  guarding reads.

Checks and activity keep their order: a failed first read still costs
GitHub nothing further.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ox rows

GitHub comment bodies often carry HTML (details, sup, img, links). The overview showed the tags as raw text.
Known tags outside code are now dropped, and an image becomes "Image: alt". Inbox rows show repo #number.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… first benchmark fixes (#319)

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
CodeQL flagged the tag pattern (polynomial backtracking on an unclosed tag) and the comment strip
(one replace can leave a new opener). A character scanner replaces both; hostile inputs are timed in the test.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The real-use benchmark found that comments on lines of the diff were counted but shown nowhere (F3).
The first activity page now also reads pulls/{n}/comments (a GET, first 100) and lists each with its
file, line and whether it is a reply. A failed read leaves the timeline usable and marks the page
partial. Whether a thread is resolved is not read; GitHub gives that only over GraphQL.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 12, 2026 8:08pm UTC
modex-app Error Error Nov 12, 2026 8:08pm UTC

Request Review

The overview always receives the write service, so the plain Comment,
Edit pull request and Request reviewers fallbacks ("This action isn't
connected yet.") were unreachable. The service is now required.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The bracket key focuses its file on the next animation frame. The keyboard test went on to
focus the filter and type at once, so on a slow runner that focus arrived mid-typing and the
filter kept only the first character. This failed the merge queue run for #506.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-code-quality

github-code-quality Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main e6e644e cr-inline-comments c599dd7 +/-
65% 66% +1%
View coverage of the 10 most impacted files.
File main e6e644e cr-inline-comments c599dd7 +/-
apps/desktop/sr...owser-bridge.ts 13% 10% -3%
apps/desktop/sr.../browser-dev.ts 94% 93% -1%
apps/desktop/sr...ngine/runner.ts 98% 98% 0%
apps/desktop/sr...read-service.ts 99% 99% 0%
apps/desktop/sr...ain/commands.ts 88% 88% 0%
apps/desktop/sr...nts/ui/Icon.tsx 99% 99% 0%
apps/desktop/sr...eview/github.ts 99% 99% 0%
apps/desktop/sr.../IconButton.tsx 97% 97% 0%
apps/store-desk...rc/main/demo.ts 94% 95% +1%
apps/desktop/sr.../ui/Tooltip.tsx 65% 67% +2%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 12, 2026 21:21 UTC

Base automatically changed from cr-viewed to main November 12, 2026 20:04
# Conflicts:
#	apps/desktop/src/main/engine/code-review/read-service.ts
#	apps/desktop/src/renderer/code-review/PrOverview.tsx
#	apps/desktop/test/code-review-read-service.test.ts
#	docs/status.md
@BunsDev

BunsDev commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Read-only delivery check at c599dd7a9fbaeb4d6946666d8859e892e6847aca: source macOS job 131458602082 passed with 2,579 unit passes and 36 skips, 526 desktop E2E passes and eight skips, eight site passes and four web passes. The checkout log identifies tested preview 17dbdddb802a1d5f2c311277a7b583fbb61b0f80; this is separate evidence from the retained local keyboard failure and focused retry.

Current main e6e644ea25cd5f428b8699e0b1e9cfbaa022e49d has an actual docs/status.md conflict with this head: fresh git merge-tree --write-tree exits 1, and GitHub reports mergeable: false / dirty. Please preserve the delivered status facts when reconciling in the owner’s worktree, then qualify the new head. No owner branch/checkout was edited and no merge-queue request was sent. This delivery check does not establish broader #319 acceptance.

@BunsDev

BunsDev commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Read-only follow-up at c599dd7a9fbaeb4d6946666d8859e892e6847aca: the authored docs/status.md diff against its own merge base c6950727 includes unrelated reversions, in addition to the current-main conflict. It reinstates #378 as open at 12/13, reduces #376 to 1/14 and #381 to 2/13, and reduces #281 to 8/27; fresh issue reads show #378 closed at 13/13, #376 at 2/14, #381 at 5/13 and #281 at 10/27. The diff also removes the delivered browser-demo and LM/CF receipt sections and restores the older landing-page description. These are changes relative to the source branch’s merge base, not merely missing later main additions. Please retain the authoritative acceptance/delivery facts and limit the status update to the inline-comments feature when reconciling. The feature code and owner checkout/branch were not edited by this audit.

@BunsDev

BunsDev commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

The source at c599dd7a9fbaeb4d6946666d8859e892e6847aca was integrated and corrected through #520, which merged through the protected queue as signed squash 967b703768d040d64456c7d118548b97a3bae35b on 2026-11-13 at 05:53:08 UTC. Its tree 6a241c26d089ac4d7daf3e4b30b23a28257010c5 exactly matches qualified integration source f9bef700390eb300d40424699193b2731d00e36c. The original source is an ancestor of that retained integration branch and independent recovery bundle; main records the protected squash. This PR is superseded by that delivery.

The actual protected checkout passed 2,587 units with 36 skips, 533 desktop E2E cases with 14 opt-in skips, eight site cases and four web cases, with no retry annotations. Both protected artifacts passed digest and ZIP-integrity checks. #520 also retains the first iPhone job cancellation and the corrected source’s complete iPhone qualification; the merge-group iPhone job itself was skipped. Its reviews corrected the three Minor feature findings and separately qualified the CI-only budget correction.

The authenticated real-PR benchmark now observes the real comments, reply and unavailable-current-line labels on #514/#506 through production reads. Resolved-thread state, inline placement and comments beyond the first 100 remain tracked limitations; parent issue acceptance, real-provider review, live-write, human/device and activation gates remain separate. The original branch and checkout are preserved for their existing owner.

@BunsDev BunsDev closed this Nov 13, 2026
auto-merge was automatically disabled November 13, 2026 05:56

Pull request was closed

This branch was successfully deployed

1 active deployment
Preview – modex — c599dd7a Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant