Skip to content

style: mechanical ruff --fix + format for engine/, l9_core/, tools/ (split 1/6 of #125)#130

Merged
cryptoxdog merged 1 commit into
mainfrom
style/ruff-mechanical-engine
Jul 23, 2026
Merged

style: mechanical ruff --fix + format for engine/, l9_core/, tools/ (split 1/6 of #125)#130
cryptoxdog merged 1 commit into
mainfrom
style/ruff-mechanical-engine

Conversation

@cryptoxdog

Copy link
Copy Markdown
Collaborator

Summary

Mechanical-only ruff --fix and ruff format remediation of pre-existing lint/format debt in engine/, l9_core/, and tools/. Extracted verbatim from #125 (commit bb92eb8), split to satisfy the 50-file PR policy limit.

Scope

  • 41 files, no behavior changes
  • Reduces ruff errors on these files from 64 (main baseline) to 26 (remaining errors need manual fixes, addressed in the follow-up manual-corrections split PR)
  • ruff format --check: all 41 files pass

Split series (replaces #125)

  1. This PR — mechanical ruff, engine/l9_core/tools
  2. Mechanical ruff, tests/
  3. Manual ruff/mypy corrections
  4. Pytest marker/config repair
  5. Makefile + lint-autofix workflow
  6. Workflow triggers + quality-gate expression fixes

Excluded from all splits per review: coverage -m unit narrowing + five --ignore test exclusions, the replacement Semgrep runner, fail-open GitGuardian gating, and the scanner allowlist hunk (superseded by #129).

@cursor

cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actions

Copy link
Copy Markdown

⚠️ Large PR Warning
Lines changed: 668
Warning threshold: 300 lines
Consider splitting for easier review

📋 Best Practices for Large Changes

  1. Refactoring + Features: Separate into 2 PRs
  2. Multiple Features: One PR per feature
  3. Database + Code: Separate migration from logic
  4. Generated Code: Separate from manual changes

This PR meets minimum requirements but is larger than recommended.

Mechanical-only remediation of pre-existing lint/format debt.
Extracted from #125 (commit bb92eb8), split to satisfy the 50-file
PR policy limit. No behavior changes.

Part 1 of 2 (companion: tests/ formatting PR).
@cryptoxdog
cryptoxdog force-pushed the style/ruff-mechanical-engine branch from 645c08f to c310a1a Compare July 22, 2026 21:20
@github-actions

Copy link
Copy Markdown

⚠️ Large PR Warning
Lines changed: 675
Warning threshold: 300 lines
Consider splitting for easier review

📋 Best Practices for Large Changes

  1. Refactoring + Features: Separate into 2 PRs
  2. Multiple Features: One PR per feature
  3. Database + Code: Separate migration from logic
  4. Generated Code: Separate from manual changes

This PR meets minimum requirements but is larger than recommended.

@cryptoxdog
cryptoxdog changed the base branch from main to fix/scanner-cypher-allowlist July 22, 2026 21:20
@sonarqubecloud

Copy link
Copy Markdown

@cryptoxdog
cryptoxdog changed the base branch from fix/scanner-cypher-allowlist to main July 23, 2026 00:50
@cryptoxdog
cryptoxdog merged commit 2018ca1 into main Jul 23, 2026
12 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant