fix(ci): workflow trigger + quality-gate expression repair (split 6/6 of #125)#135
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
❌ Too Many Files Changed ❌ PR Too Large 📋 Best Practices for Large Changes
🚫 This PR is blocked from merging until size limits are met. |
This was referenced Jul 22, 2026
Filtered extraction from #125 (commit 9b0d03c), workflows only: - ci.yml / codeql.yml / docker-build.yml / supply-chain.yml / release-drafter.yml: replace ${{ vars.* }} branch triggers with literal main/develop — GitHub never evaluates expressions in the 'on:' block, so these workflows never triggered - ci.yml: install lint deps from requirements-ci.txt (canonical set) and make mypy consistent + blocking (was || echo non-blocking) - compliance.yml: delegate Cypher injection check to the canonical tools/contract_scanner.py instead of a second divergent regex; align mypy invocation with the CI gate (drop --strict divergence) - refactoring-validation.yml: gate the deep validation to refactor/ branches or manual dispatch; align mypy invocation - ci-quality.yml: fix needs.lint-format / needs.secrets-scan / needs.yaml-validate expressions to bracket syntax (hyphenated job ids resolve to empty string with dot syntax, so gates never fired); add missing semgrep failure branch to the quality-gate summary Deliberately excluded per review: replacement Semgrep runner, GitGuardian fail-open gating, coverage -m unit narrowing and the five --ignore test exclusions, tools/contract_scanner.py hunk (#129). All 8 workflow YAMLs parse cleanly.
cryptoxdog
force-pushed
the
fix/workflow-triggers-gates
branch
from
July 22, 2026 21:20
955777c to
f686635
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workflow-only extraction from #125 (commit 9b0d03c), with the risky pieces removed.
Changes
${{ vars.* }}branch triggers → literalmain/develop(expressions inon:are never evaluated, so these workflows never triggered)requirements-ci.txt; mypy consistent + blocking (was `tools/contract_scanner.py; mypy aligned with CI gate (drops--strictdivergence)refactor/branches or manual dispatch; mypy alignedneeds.lint-format→needs['lint-format']bracket syntax (dot syntax on hyphenated job ids silently resolves empty, so the gate never fired); adds the missing semgrep failure branchExcluded per review (not in this PR)
returntocorp/semgrep-actionstep kept as-is-m unitnarrowing + five--ignoretest exclusionstools/contract_scanner.pyhunk — superseded by fix(ci): allowlist sanitized Cypher callsites in contract scanner (supersedes #124 scanner fix) #129Verification
See #130 for the full split-series map replacing #125.