Skip to content

style: mechanical ruff --fix + format for tests/ (split 2/6 of #125)#131

Merged
cryptoxdog merged 1 commit into
mainfrom
style/ruff-mechanical-tests
Jul 23, 2026
Merged

style: mechanical ruff --fix + format for tests/ (split 2/6 of #125)#131
cryptoxdog merged 1 commit into
mainfrom
style/ruff-mechanical-tests

Conversation

@cryptoxdog

Copy link
Copy Markdown
Collaborator

Summary

Mechanical-only ruff --fix and ruff format remediation of pre-existing lint/format debt in tests/. Extracted verbatim from #125 (commit bb92eb8), split to satisfy the 50-file PR policy limit. No behavior changes.

Companion to #130 (engine/l9_core/tools). See #130 for the full split-series map replacing #125.

@cursor

cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actions

Copy link
Copy Markdown

⚠️ Large PR Warning
Lines changed: 403
Warning threshold: 300 lines
Consider splitting for easier review

📋 Best Practices for Large Changes

  1. Refactoring + Features: Separate into 2 PRs
  2. Multiple Features: One PR per feature
  3. Database + Code: Separate migration from logic
  4. Generated Code: Separate from manual changes

This PR meets minimum requirements but is larger than recommended.

from engine.config.loader import DomainPackLoader
from engine.sync.generator import SyncGenerator

loader = DomainPackLoader(domains_dir=Path(__file__).parent.parent.parent / "domains")
loader = DomainPackLoader(
domains_dir=Path(__file__).parent.parent.parent / "domains"
)
loader = DomainPackLoader(domains_dir=Path(__file__).parent.parent.parent / "domains")
import engine.gates.compiler as gc
import engine.sync.generator as sg
import engine.scoring.assembler as sa
import engine.sync.generator as sg
Mechanical-only remediation of pre-existing lint/format debt.
Extracted from #125 (commit bb92eb8), split to satisfy the 50-file
PR policy limit. No behavior changes.

Part 2 of 2 (companion: engine/l9_core/tools formatting PR).
@cryptoxdog
cryptoxdog force-pushed the style/ruff-mechanical-tests branch from f0116ad to 87819d4 Compare July 22, 2026 21:20
@cryptoxdog
cryptoxdog changed the base branch from main to style/ruff-mechanical-engine July 22, 2026 21:20
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Too Many Files Changed
Changed: 73 files
Limit: 50 files
Action Required: Split into multiple focused PRs

PR Too Large
Lines changed: 1078
Limit: 1000 lines
Action Required: Break into smaller, atomic PRs

📋 Best Practices for Large Changes

  1. Refactoring + Features: Separate into 2 PRs
  2. Multiple Features: One PR per feature
  3. Database + Code: Separate migration from logic
  4. Generated Code: Separate from manual changes

🚫 This PR is blocked from merging until size limits are met.

@cryptoxdog
cryptoxdog changed the base branch from style/ruff-mechanical-engine to main July 23, 2026 00:51
@cryptoxdog
cryptoxdog merged commit 1d6b8d9 into main Jul 23, 2026
11 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant