fix: manual ruff/mypy corrections (split 3/6 of #125)#132
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
📋 Best Practices for Large Changes
✅ This PR meets minimum requirements but is larger than recommended. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| import engine.gates.compiler as gc | ||
| import engine.sync.generator as sg | ||
| import engine.scoring.assembler as sa | ||
| import engine.sync.generator as sg |
Non-autofixable remediation extracted from #125 (commits f4cca2f, a539a17, 0916321, eb5e8af): - manual Ruff fixes across engine/ and affected tests - mypy errors blocking the ci-quality lint gate (outcomes engine, P2_9_llm_schemas, and related modules) - wrong keyword arguments in GraphSyncClient envelope builder - wrong DomainPackLoader keyword argument in test_injection.py - pyproject: per-file N818 ignore for chassis/errors.py (stable serialized error-type name; renaming would break wire format) Local verification: ruff format --check (20 files pass), ruff check (all pass), mypy engine/ --config-file=pyproject.toml --ignore-missing-imports --exclude chassis (no issues, 131 files).
79c36af to
908811d
Compare
|
❌ Too Many Files Changed ❌ PR Too Large 📋 Best Practices for Large Changes
🚫 This PR is blocked from merging until size limits are met. |
|
1 participant
Summary
Manual (non-autofixable) Ruff and MyPy remediation extracted from #125 (commits f4cca2f, a539a17, 0916321, eb5e8af).
Scope (21 files)
engine/and affected testsGraphSyncClientenvelope builderDomainPackLoaderkwarg intests/security/test_injection.pypyproject.toml: per-fileN818ignore forchassis/errors.py(stable serialized error-type name)Local verification
ruff format --check— 20 files passruff check— all passmypy engine/ --config-file=pyproject.toml --ignore-missing-imports --exclude chassis— no issues in 131 filesNotes