Repository navigation
fix: bare select() over a subquery or union selects every alias - #43
Merged
Merged
Conversation
`select()` with no arguments expanded the source's declared columns. A derived source (`fromQuery`, `fromUnion`) has none until its SELECT is evaluated, so the expansion was empty and compile died with `select() is required` — though the type promised every column. The expansion now waits for compile, which reads the source's aliases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Makisuo
added this pull request to stack #46
October 23, 2026 00:18
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 23, 2026
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CH.fromQuery(inner, "w").select()andCH.fromUnion(u, "u").select()died withQueryBuilderDefect: select() is required, though the type says "every column". A derived source has no column list until its own SELECT is evaluated, so the expansion was empty. It is now resolved at compile from the source's aliases (typed or not).Verification: tests in
subquery.test.tsfor both sources; the plan fuzzer wraps about half its plans this way — 12k queries vs the model at 20×, previously all skipped; full suite.Stack (merge bottom-up):
🤖 Generated with Claude Code