Repository navigation
fix: fail with QueryBuilderError instead of throwing on unusable values - #42
Merged
Merged
Conversation
The hostile-value fuzzer found compile paths that threw a raw TypeError or RangeError instead of recording a failure: - describe() formatted a bigint with JSON.stringify, which throws; - like/notLike/ilike called .toFragment() on any non-string pattern; - lit() wrote String(value) for a non-number, and Math.abs threw on a bigint; - arithmetic read .schema off a non-numeric operand; - an invalid Date reached DateTime.makeUnsafe; - the Postgres timestamp codec checked strings on the encoded side only, so an unparseable string or invalid Date reached toISOString; - a non-expression in a select record had .toFragment() called on it. Values a request can supply now fail as QueryBuilderError InvalidLiteral; a select record's shape is source, so it is a QueryBuilderDefect, as errors.ts and the orderBy precedent say. The fuzzer gains `lit` and arithmetic sites and accepts a defect only at source-shaped sites. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Makisuo
added this pull request to stack #46
October 23, 2026 00:18
This was referenced Oct 23, 2026
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hostile-value fuzzer found compile paths that threw a raw
TypeError/RangeErrorinstead of failing:describe()→JSON.stringifythrowslike/notLike/ilikepatternpattern.toFragment is not a functionlit({}),lit(Symbol())[object Object];lit(0n)threw onMath.absCannot read properties of undefined (reading 'schema')DateoperandIllegalArgumentError: Invalid dateRangeError: Invalid time valuefromtoISOStringselectrecordselectExprs[alias].toFragment is not a functionValues a request can supply now fail as
QueryBuilderErrorInvalidLiteral. A select record's shape is written in source, so it is aQueryBuilderDefectnaming the alias — the rule inerrors.ts, like a malformedorderBy.Verification:
failure.test.tscases for each; hostile fuzz (now also atlitand arithmetic sites) at 200× with no known issues — 100k values per dialect; full suite.Stack (merge bottom-up):
🤖 Generated with Claude Code