Repository navigation
fix: parenthesise an arithmetic expression passed as an argument - #41
Merged
Merged
Conversation
`arith` wrote `${lhs} ${op} ${rhs}` with no parentheses. For a chain that
is documented: it follows SQL precedence. But a compound argument lost its
boundary too — `$.a.sub($.b.add(1))` compiled to `a - b + 1` — and no call
order can express `a - (b + 1)` then. A right-hand argument built by
`arith` is now parenthesised; chained SQL is unchanged.
The fuzz model groups arguments the same way, and FUZZ_STRICT accepts a
list of known-issue ids to re-enable just those.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Makisuo
added this pull request to stack #46
October 23, 2026 00:18
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$.a.sub($.b.add(1))compiled toa - b + 1. Chains following SQL precedence is documented ($.a.sub(1).div(2)isa - 1 / 2), but an argument is not a chain and no call order could expressa - (b + 1). A right-hand argument that is itself arithmetic is now parenthesised; chained SQL is unchanged.docs/expressions.mdsays how to group (pass the group as an argument).The fuzz model applies the documented chain precedence and keeps arguments whole;
FUZZ_STRICTaccepts a list of known-issue ids.Verification: doc-backed test
An arithmetic argument keeps its parentheses; plan fuzz at 20× on Postgres and ClickHouse (12k queries vs the model, nested arithmetic no longer skipped); full suite.Stack (merge bottom-up):
🤖 Generated with Claude Code