Copy source metadata when creating a single-camera soft clone - #1846
Open
PaulHax wants to merge 1 commit into
Open
Copy source metadata when creating a single-camera soft clone#1846PaulHax wants to merge 1 commit into
PaulHax wants to merge 1 commit into
Conversation
This was referenced Aug 14, 2026
PaulHax
marked this pull request as ready for review
August 14, 2026 03:45
BryonLewis
approved these changes
Aug 14, 2026
BryonLewis
left a comment
Collaborator
There was a problem hiding this comment.
I can understand why this is needed. I think before the metadata editing we assumed that the metadata was attached to the video and that only annotations would be changed from clones. That is no longer true given the other things that are being stored in the metadata now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy source metadata when DIVE creates a single-camera soft clone
Failure case
A single-camera soft clone used the source metadata object directly. The source and clone then
shared one mutable object. Clone markers and later nested changes could modify the source metadata.
The multicamera clone path already makes an independent copy.
Steps to reproduce
createSoftCloneserver entry point.the other object.
This object-isolation defect has no supported user-interface reproduction. The automated
createSoftClonetest is the authoritative reproduction.Changes
createSoftClonepath.Scope
This PR changes
crud_dataset.pyandtest_multicam_export_clone.py. It does not test a liveGirder clone, the Mongo save boundary, or a viewer reload.
Hierarchy prerequisite
The hierarchy is stored in dataset metadata, so a soft clone must copy that metadata without
changing or sharing the source object.
Stack
This is PR 3 of 9. Previous: preserve Desktop import warnings.
Next: add hierarchical track classification.
This PR is stacked on
desktop-warning-preservation.Commit:
4ad85091 Copy source metadata when creating a single-camera soft clone.