Skip to content

Copy source metadata when creating a single-camera soft clone #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulHax wants to merge 1 commit into from
+41 −1
Open

Copy source metadata when creating a single-camera soft clone #1846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/dive_server/crud_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def _create_single_camera_soft_clone(
reuseExisting=False,
creator=owner,
)
cloned_folder['meta'] = source_folder['meta']
cloned_folder['meta'] = copy.deepcopy(source_folder['meta'])
media_source_folder = crud.getCloneRoot(owner, source_folder)
cloned_folder[constants.ForeignMediaIdMarker] = str(media_source_folder['_id'])
cloned_folder['meta'][constants.PublishedMarker] = False
Expand Down
40 changes: 40 additions & 0 deletions server/tests/test_multicam_export_clone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,46 @@ def _descriptor(name: str):
return {'itemId': f'{name}-id', 'name': name}


@patch('dive_server.crud_dataset.crud_annotation.clone_annotations')
@patch('dive_server.crud_dataset.crud.get_or_create_auxiliary_folder')
@patch('dive_server.crud_dataset.crud.getCloneRoot')
@patch('dive_server.crud_dataset.Folder')
def test_create_single_camera_soft_clone_copies_metadata(
folder_cls, get_clone_root_mock, _aux, _clone_ann
):
owner = {'login': 'tester'}
source = {
'_id': 'source-id',
'name': 'source-dataset',
'meta': {
'annotate': True,
'type': 'image-sequence',
'custom': {'labels': ['fish'], 'settings': {'enabled': True}},
},
}
parent = {'_id': 'dest-parent'}
cloned_folder = {'_id': 'clone-id', 'name': 'Clone dataset'}
folder_cls.return_value.createFolder.return_value = cloned_folder
get_clone_root_mock.return_value = source

result = crud_dataset.createSoftClone(owner, source, parent, 'Clone dataset', None)

assert result is cloned_folder
source['meta']['custom']['labels'].append('shark')
source['meta']['custom']['settings']['enabled'] = False
assert cloned_folder['meta']['custom'] == {
'labels': ['fish'],
'settings': {'enabled': True},
}

cloned_folder['meta']['custom']['labels'].append('ray')
cloned_folder['meta']['custom']['settings']['enabled'] = None
assert source['meta']['custom'] == {
'labels': ['fish', 'shark'],
'settings': {'enabled': False},
}


@patch('dive_server.crud_dataset.find_json_calibration_item_id', return_value=None)
@patch('dive_server.crud_dataset.find_calibration_item_id', return_value=None)
@patch('dive_server.crud_dataset.crud_annotation.clone_annotations')
Expand Down
Loading