Replace mutable merged tracks with read-only projections - #1849
Draft
PaulHax wants to merge 3 commits into
Draft
Conversation
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace mutable merged tracks with read-only projections
The multicamera track list returned a cloned
Trackmodel. The clone still had mutation methodsand notification state. A caller could change the clone without changing the stored camera tracks.
The single-camera path returned a live model. Thus, the two paths had different read and write
behavior.
Changes
TrackProjectionfor logical-track reads.CameraStorecommands.
Track.merge.An edit in any camera invalidates the related projection. This includes an edit in a camera that is
not the canonical camera.
Manual tests
Test data: download and extract classification.zip. Paths below are relative to
dive-classification-test-data/.Multicamera row edits
dive-classification-test-data/classification/multicamera-linked-types/.cameras.
Verify: The logical-track view shows the saved note, attributes, and keyframe geometry after reload.
Projection refresh from either camera
dive-classification-test-data/multicamera/divergent-classification-replicas/.Verify: The list and Track Details refresh after either camera track changes.
Stack
This is PR 6 of 9. Previous: centralize classification changes.
Next: make lifecycle operations classification-safe.
This PR is stacked on
hierarchical-classification-pr2-mutations.Overall: 24 files, +808/-151. Commits:
523556b9through9bc865e1.