Preserve warnings from every Desktop import file - #1845
Open
PaulHax wants to merge 1 commit into
Open
Conversation
This was referenced Aug 14, 2026
PaulHax
marked this pull request as ready for review
August 14, 2026 03:45
BryonLewis
approved these changes
Aug 14, 2026
BryonLewis
left a comment
Collaborator
There was a problem hiding this comment.
seems simple enough, most changes were just tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve warnings from every Desktop import file
Failure case
A Desktop import can contain more than one primary annotation file. Before this change, each file
replaced the warnings from the preceding file. The import report showed warnings only from the last
file.
Supported annotation data was still imported. However, the missing warnings could hide skipped or
changed data from earlier files.
Steps to reproduce
Use
dive-classification-test-data/coco/rle-mask-warning-aggregation/from the test-data ZIP builtby PaulHax/dive-devkit.
media/image-sequence/as the image sequence.ingestDataFilesfunction withrle-warning-fish.coco.jsonandrle-warning-shark.coco.jsonin the primary input list.warning list.
Changes
Scope
This PR changes
common.tsandcommon.spec.ts. It does not change the warning text or the importdialog. The tests use the exported Desktop ingestion entry point. They do not use a live Electron
import dialog.
Hierarchy prerequisite
The hierarchy feature does not cause this bug, but its KWCOCO imports add warnings that the existing
bug could discard.
Stack
This is PR 2 of 9. Previous: TypeScript spec lint.
Next: isolate soft-clone metadata.
This PR is stacked on
eslint-unused-directives.Commit:
a6737794 Preserve warnings from every desktop import file.