Wrap yaw error when checking Reeds-Shepp goal pose - #1422
Open
huxiaoyi-ovo wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-pi/+piwraparound correctlyProblem
RRTStarReedsShepp.search_best_goal_node()currently checks the goal yaw with a direct subtraction:Angles are periodic, so poses near opposite sides of the
-pi/+pirepresentation boundary can be physically very close while their raw numeric difference is almost2*pi.For example,
pi - 0.005and-pi + 0.005differ by only0.01 radon the circle, which is within the planner's 1-degree goal threshold, but the current check sees a difference of about6.273 radand rejects the node.Fix
Compute the wrapped signed angle using
atan2(sin(diff), cos(diff))before applying the existing threshold.Tests
Added
test_goal_yaw_wraparound, which places the start and goal at the same position with headings straddling the-pi/+piboundary and verifies that the start node is accepted as satisfying the goal yaw threshold.