Enable terminal lifecycle recovery in dogfood#12859
Draft
vorporeal wants to merge 1 commit into
Draft
Conversation
This was referenced Jun 20, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 20, 2026
Co-Authored-By: Oz <oz-agent@warp.dev>
da9c6a2 to
c12ed03
Compare
b073e5a to
29b42f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Stack PR 8/8; depends on #12858.
Context
The preceding PRs land the coordinator and recovery behavior with
TerminalLifecycleRecoverydisabled by default. That protects production while the newPrecmdcompletion metadata fields propagate through stable clients, but it also means the recovery path will not receive real-world exercise or diagnostics unless it is enabled for a narrower population first.Shared-session version skew is the main reason to separate internal enablement from broad rollout: newer viewers recover most reliably once more sharers have reached a stable version that emits the completion metadata added in #12853.
Approach and rollout boundary
This PR enables
TerminalLifecycleRecoveryonly inDOGFOOD_FLAGS. Preview and release defaults remain disabled, so the stack can collect internal telemetry and manual validation without changing behavior for broader channels. Production promotion is intentionally outside this stack and should happen only after the protocol fields have had sufficient stable-release soak time and dogfood diagnostics show the transition policy is behaving as intended.There are no recovery implementation changes in this PR; it changes only the default audience for the already-gated behavior.
Review guidance
Testing
cargo check -p warp --tests,./script/format, andgit diff --check.