Skip to content

Enable terminal lifecycle recovery in dogfood#12859

Draft
vorporeal wants to merge 1 commit into
david/recover-block-lifecycle-from-precmdfrom
david/enable-terminal-lifecycle-recovery-dogfood
Draft

Enable terminal lifecycle recovery in dogfood#12859
vorporeal wants to merge 1 commit into
david/recover-block-lifecycle-from-precmdfrom
david/enable-terminal-lifecycle-recovery-dogfood

Conversation

@vorporeal

@vorporeal vorporeal commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Description

Stack PR 8/8; depends on #12858.

Context

The preceding PRs land the coordinator and recovery behavior with TerminalLifecycleRecovery disabled by default. That protects production while the new Precmd completion metadata fields propagate through stable clients, but it also means the recovery path will not receive real-world exercise or diagnostics unless it is enabled for a narrower population first.

Shared-session version skew is the main reason to separate internal enablement from broad rollout: newer viewers recover most reliably once more sharers have reached a stable version that emits the completion metadata added in #12853.

Approach and rollout boundary

This PR enables TerminalLifecycleRecovery only in DOGFOOD_FLAGS. Preview and release defaults remain disabled, so the stack can collect internal telemetry and manual validation without changing behavior for broader channels. Production promotion is intentionally outside this stack and should happen only after the protocol fields have had sufficient stable-release soak time and dogfood diagnostics show the transition policy is behaving as intended.

There are no recovery implementation changes in this PR; it changes only the default audience for the already-gated behavior.

Review guidance

  • Is the flag enabled only for dogfood and explicitly absent from preview and release defaults?
  • Does this PR avoid changing recovery logic or broadening the rollout beyond the intended internal soak?
  • Are the remaining production-promotion criteria clear and intentionally deferred?

Testing

  • Added a feature-flag regression verifying recovery is dogfood-enabled but absent from preview and release defaults.
  • Final-stack validation: focused lifecycle tests, cargo check -p warp --tests, ./script/format, and git diff --check.

vorporeal commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

@vorporeal vorporeal changed the title Enable terminal lifecycle recovery for dogfood Enable terminal lifecycle recovery in dogfood Jun 20, 2026
Co-Authored-By: Oz <oz-agent@warp.dev>
@vorporeal vorporeal force-pushed the david/recover-block-lifecycle-from-precmd branch from da9c6a2 to c12ed03 Compare June 20, 2026 05:14
@vorporeal vorporeal force-pushed the david/enable-terminal-lifecycle-recovery-dogfood branch from b073e5a to 29b42f2 Compare June 20, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant