Distinguish Precmd hooks with completion metadata from prompt-only hooks#12854
Draft
vorporeal wants to merge 2 commits into
Draft
Distinguish Precmd hooks with completion metadata from prompt-only hooks#12854vorporeal wants to merge 2 commits into
vorporeal wants to merge 2 commits into
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 20, 2026
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
6897525 to
709d251
Compare
66999d5 to
05ed27e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Stack PR 3/8; depends on #12853.
Context
Once the new fields begin reaching clients, the parser must distinguish three meaningfully different inputs. A new sharer's
Precmdcontains a complete completion identity; an older sharer'sPrecmdcontains prompt metadata only; and a payload containing just one completion field is malformed. Treating those cases as one partially optional value would spread ambiguity into the model and risk using incomplete or prompt-only evidence as proof that a command completed.Approach
This PR makes the distinction explicit at the parser boundary. A canonical
PrecmdValuecontains non-optionalCompletionMetadataplus reusablePromptMetadata; a prompt with neither completion field becomes a separate prompt-only event; and a prompt with exactly one completion field is rejected. Both JSON and key-value decoding follow the same classification rule.The prompt-only portion is also separated so
BlockList,Block,HeaderGrid, restoration, and cached prompt paths do not need to know about completion evidence. Canonical completion metadata reachesTerminalModel, but this PR intentionally sendsPrecmdhooks with completion metadata and prompt-onlyPrecmdhooks through the existing prompt behavior. Recovery is deferred until the normal mutation pipeline and lifecycle gate exist.Review guidance
PromptMetadatarefactor preserve current prompt and lifecycle behavior despite changing many call sites?Testing
cargo check -p warp --tests,./script/format, andgit diff --check.