Add command completion metadata to Precmd#12853
Draft
vorporeal wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 20, 2026
Co-Authored-By: Oz <oz-agent@warp.dev>
6897525 to
709d251
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Stack PR 2/8; depends on #12852.
Context
CommandFinishedis Warp's early completion signal, whilePrecmdarrives later when the shell is ready to display the next prompt. IfCommandFinishedis lost butPrecmdstill arrives, the currentPrecmdpayload does not carry enough information to prove which command completed, preserve its real exit code, or identify the exact next block. Recovery must not guess any of those values.This matters especially for shared sessions: viewers parse the raw shell hooks emitted by the sharer's installed client. When recovery eventually launches, it will only be useful for sessions whose sharers already emit the additional completion metadata fields.
Approach and sequencing
Each supported shell now captures the previous command's exit code and allocates the next block ID once, then sends that exact pair in both
CommandFinishedandPrecmd. The fields are redundant by design: normal clients continue using the earlierCommandFinished, while a laterPrecmdcan serve as trustworthy reconciliation evidence if the earlier hook was dropped.This is intentionally a standalone, behavior-preserving PR so it can reach stable ahead of the recovery implementation. That lead time increases the population of shared-session sharers sending
Precmdhooks with completion metadata before newer viewers begin acting on them. Existing clients continue ignoring unknown JSON fields, and the current key-value decoder accepts these two fields without changing lifecycle behavior.Review guidance
Testing
Precmdfields.cargo check -p warp --tests,./script/format, andgit diff --check.