Repository navigation
Conversation
This was referenced Oct 2, 2026
erichare
force-pushed
the
fix/rerank-candidate-pagination
branch
from
October 2, 2026 20:21
bdb8809 to
6364be7
Compare
4 tasks done
erichare
marked this pull request as ready for review
October 5, 2026 20:35
erichare
added this pull request to stack #2608
October 5, 2026 20:35
erichare
force-pushed
the
fix/rerank-candidate-pagination
branch
from
October 5, 2026 20:36
35f08a5 to
6144372
Compare
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
erichare
force-pushed
the
fix/rerank-candidate-pagination
branch
from
October 7, 2026 01:09
6144372 to
bfcd678
Compare
erichare
force-pushed
the
fix/rerank-candidate-pagination
branch
from
October 15, 2026 15:04
bfcd678 to
1a413a1
Compare
erichare
removed this pull request from stack #2608
October 15, 2026 15:04
erichare
added this pull request to stack #2646
October 15, 2026 15:04
erichare
force-pushed
the
fix/rerank-candidate-pagination
branch
from
October 15, 2026 15:26
1a413a1 to
ec4bda6
Compare
4 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a dedicated candidate-read operation for
findAndRerank. It follows continuation pages and shares each leg's limit across its queries.Reuses query building, document parsing, metrics, and sorting safeguards. Candidate construction supplies explicit page sizes and the full sorted-result budget to the shared resolver. Ordinary
findkeeps its existing pagination and sorted-result cap.Depends on #2606, which is stacked on the planner/read-legs refactor in #2637.
Validation: 280 focused parser, planner, builder, resolver, collection-operation, and candidate-pagination tests pass on Java 21. Covers underfilled pages, shared candidate budgets, sorted/unsorted limits, ordinary find pagination, and vector page-size bounds.
Which issue(s) this PR fixes:
Fixes #2599 (completes #2606).
Checklist