Repository navigation
Conversation
This was referenced Oct 2, 2026
erichare
force-pushed
the
fix/rerank-candidate-resolution
branch
from
October 2, 2026 20:20
18eb142 to
104cc98
Compare
erichare
marked this pull request as ready for review
October 5, 2026 20:13
erichare
added this pull request to stack #2608
October 5, 2026 20:35
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
erichare
force-pushed
the
fix/rerank-candidate-resolution
branch
from
October 7, 2026 01:09
d4c2b54 to
af04e14
Compare
Reverts whitespace-only reindent of 24 existing text blocks so the PR diff only shows the new candidate read tests.
erichare
force-pushed
the
fix/rerank-candidate-resolution
branch
from
October 15, 2026 15:02
af04e14 to
8df7a12
Compare
erichare
removed this pull request from stack #2608
October 15, 2026 15:04
erichare
added this pull request to stack #2646
October 15, 2026 15:04
| private Operation<CollectionSchemaObject> resolveCollectionCommand( | ||
| CommandContext<CollectionSchemaObject> commandContext, | ||
| FindCommand command, | ||
| boolean candidateRead) { |
Contributor
There was a problem hiding this comment.
I don't really understand, a boolean flag is just another workaround/hack, and your next PR 2607 reuses this boolean. It will be hard to maintain and hard to understand if we add more boolean flags. I think we need to discuss this
Contributor
Author
There was a problem hiding this comment.
Removed candidateRead in cead439 and carried the change into #2607 in 60aaec1. Each entry point now supplies concrete vector/lexical page sizes and a sorted-result limit. Shared query resolution no longer branches on the caller. #2607 keeps pagination in CollectionCandidateReadOperation and supplies the full candidate budget for sorted reads. Ordinary find retains its existing page sizes and sorted-result cap.
258 focused tests pass for #2606 and 280 for #2607. Does this separation address the concern, or were you thinking of a different boundary?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Makes each
findAndRerankretrieval leg use the limit in its innerfindcommand instead of passing limits throughCommandContext.COMMAND_FIELD_VALUE_INVALID.findbehavior and the vector-search limit.Depends on #2637. PR #2607 adds pagination to collect the full candidate set.
Validation: 258 focused parser, planner, builder, resolver, and collection-operation tests pass on Java 21. Includes zero/negative user limits and candidate vector page-size bounds.
Which issue(s) this PR fixes:
Refs #2599 (first part).
Checklist