Repository navigation
test: cover successful findAndRerank through the Nvidia HTTP client - #2605
Conversation
📈 Unit Test Coverage Delta vs Main Branch
|
Unit Test Coverage Report
|
DocumentScoresDesc serializes per-document scores under "scores", not "$scores". The wrong path made every $rerank assertion see an empty list and let the $vectorRank/$bm25Rank checks pass vacuously.
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Integration Test Coverage Report (dse69-it)
|
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Integration Test Coverage Report (hcd-it)
|
| } | ||
|
|
||
| @Test | ||
| void explicitOverridesRerankBeforeProjectionAndApplyFinalLimit() { |
There was a problem hiding this comment.
nit: explicitOverridesRerankBeforeProjectionAndApplyFinalLimit shows that all three candidates are reranked before limit: 2 applies, since three passages are sent. But the top two by score, high and middle, are also the first two documents before sorting (ScoredDocumentMerger keeps candidates in a HashMap keyed by _id, which yields high, middle, low for these ids). So this test alone would still pass if the result were cut before sorting.
Could the scores be chosen so the top two differ from that order? For example, ids a, b, c with passage scores 1, 8 and 4 should return b, c, while the order before sorting is a, b, c.
2 participants
What this PR does:
Adds integration tests that complete
findAndRerankusing a local HTTP reranker and the production Nvidia client.This is the test foundation for #2606 and #2607. Unit tests and DSE/HCD integration tests pass in CI.
Which issue(s) this PR fixes:
Fixes #2600.
Checklist