Skip to content

feat: add oauth.v2.completeShortTokenRotation method - #1711

Closed
zimeg wants to merge 1 commit into
zimeg-feat-oauth-v2-begin-short-token-rotationfrom
zimeg-feat-oauth-v2-complete-short-token-rotation
Closed

zimeg wants to merge 1 commit into
zimeg-feat-oauth-v2-begin-short-token-rotationfrom
zimeg-feat-oauth-v2-complete-short-token-rotation

Conversation

@zimeg

@zimeg zimeg commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

This pull request adds the oauth.v2.completeShortTokenRotation method to the sync and async clients.

  • oauthV2CompleteShortTokenRotation takes clientId, clientSecret, token, and newToken. token is the original short token from oauth.v2.beginShortTokenRotation and is sent in the Authorization header.
  • The response echoes the now active token in token.

This is part 2 of 3 in the oauth stack, which adds the oauth methods one at a time. This pull request is in batch B6 oauth tokens. Each pull request builds on the one before it and merges on its own, bottom to top. The stack starts on main.

  1. feat: add oauth.v2.beginShortTokenRotation method #1710 oauth.v2.beginShortTokenRotation
  2. feat: add oauth.v2.completeShortTokenRotation method #1711 oauth.v2.completeShortTokenRotation 👈 this pull request
  3. feat: add oauth.v2.user.access method #1712 oauth.v2.user.access

Testing

Run the remote tests for this layer:

  • test_with_remote_apis.methods.oauth_Test#beginShortTokenRotation+completeShortTokenRotation with SLACK_SDK_TEST_USER_TOKEN

The test sends a real user token with the example client_id, client_secret, and new_token from the docs, and the API answers with the documented invalid_client_id. A full rotation needs a token with a short secret.

Each layer was checked against the live API by running its own remote test, along with the earlier tests in its stack.

Category

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

🤖 Generated with Claude Code

@codecov

codecov Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.84%. Comparing base (1b7fbbb) to head (6a2b204).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                                 Coverage Diff                                  @@
##             zimeg-feat-oauth-v2-begin-short-token-rotation    #1711      +/-   ##
====================================================================================
+ Coverage                                             73.81%   73.84%   +0.03%     
- Complexity                                             4749     4755       +6     
====================================================================================
  Files                                                   487      487              
  Lines                                                 14820    14830      +10     
  Branches                                               1536     1536              
====================================================================================
+ Hits                                                  10939    10951      +12     
+ Misses                                                 2963     2962       -1     
+ Partials                                                918      917       -1     
Flag Coverage Δ
jdk-14 73.84% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg

zimeg commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

Closing for now. Short-secret tokens only exist for apps created before August 2016, so these rotation methods aren't in scope for this release.

@zimeg zimeg closed this Nov 18, 2026
@zimeg
zimeg deleted the zimeg-feat-oauth-v2-complete-short-token-rotation branch November 18, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant