Repository navigation
Conversation
This was referenced Nov 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## zimeg-feat-oauth-v2-begin-short-token-rotation #1711 +/- ##
====================================================================================
+ Coverage 73.81% 73.84% +0.03%
- Complexity 4749 4755 +6
====================================================================================
Files 487 487
Lines 14820 14830 +10
Branches 1536 1536
====================================================================================
+ Hits 10939 10951 +12
+ Misses 2963 2962 -1
+ Partials 918 917 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
force-pushed
the
zimeg-feat-oauth-v2-begin-short-token-rotation
branch
from
November 18, 2026 06:16
73c2a92 to
1b7fbbb
Compare
zimeg
force-pushed
the
zimeg-feat-oauth-v2-complete-short-token-rotation
branch
from
November 18, 2026 06:16
b65bf3f to
6a2b204
Compare
Member
Author
|
Closing for now. Short-secret tokens only exist for apps created before August 2016, so these rotation methods aren't in scope for this release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the
oauth.v2.completeShortTokenRotationmethod to the sync and async clients.oauthV2CompleteShortTokenRotationtakesclientId,clientSecret,token, andnewToken.tokenis the original short token fromoauth.v2.beginShortTokenRotationand is sent in theAuthorizationheader.token.This is part 2 of 3 in the
oauthstack, which adds theoauthmethods one at a time. This pull request is in batch B6 oauth tokens. Each pull request builds on the one before it and merges on its own, bottom to top. The stack starts onmain.oauth.v2.beginShortTokenRotationoauth.v2.completeShortTokenRotation👈 this pull requestoauth.v2.user.accessTesting
Run the remote tests for this layer:
test_with_remote_apis.methods.oauth_Test#beginShortTokenRotation+completeShortTokenRotationwithSLACK_SDK_TEST_USER_TOKENThe test sends a real user token with the example
client_id,client_secret, andnew_tokenfrom the docs, and the API answers with the documentedinvalid_client_id. A full rotation needs a token with a short secret.Each layer was checked against the live API by running its own remote test, along with the earlier tests in its stack.
Category
Requirements
🤖 Generated with Claude Code