Skip to content

feat(methods): add oauth.v2.completeShortTokenRotation method example - #139

Closed
zimeg wants to merge 1 commit into
zimeg-feat-oauth-v2-examples-begin-short-token-rotationfrom
zimeg-feat-oauth-v2-examples-complete-short-token-rotation
Closed

zimeg wants to merge 1 commit into
zimeg-feat-oauth-v2-examples-begin-short-token-rotationfrom
zimeg-feat-oauth-v2-examples-complete-short-token-rotation

Conversation

@zimeg

@zimeg zimeg commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

This pull request adds a method example for oauth.v2.completeShortTokenRotation in methods/src/main/java/oauth/v2/OAuthV2CompleteShortTokenRotation.java, and lists it in methods/README.md.

  • The arguments match the siblings in bolt-js-examples and bolt-python-examples, with the example values from the reference page.

This is part 2 of 3 in the oauth stack, which adds the oauth method examples one at a time to match the SDK stack (slackapi/java-slack-sdk#1710, slackapi/java-slack-sdk#1711, slackapi/java-slack-sdk#1712). This pull request is in batch B6 oauth tokens. Each pull request builds on the one before it and merges on its own, bottom to top. The stack starts on main.

  1. feat(methods): add oauth.v2.beginShortTokenRotation method example #138 oauth.v2.beginShortTokenRotation
  2. feat(methods): add oauth.v2.completeShortTokenRotation method example #139 oauth.v2.completeShortTokenRotation 👈 this pull request
  3. feat(methods): add oauth.v2.user.access method example #140 oauth.v2.user.access

Dependency: stays a draft

This depends on slackapi/java-slack-sdk#1711, which adds oauthV2CompleteShortTokenRotation to slack-api-client. mvn compile fails against the pinned 1.55.0 until that ships in a release, as expected. This PR stays a draft until then, and the slack-api-client pin gets bumped to that release in this stack.

Testing

With slackapi/java-slack-sdk#1711 installed locally (./scripts/install_local.sh) and the pin pointed at that snapshot:

  1. cd methods. The method takes the app's client credentials, so no SLACK_TOKEN is needed.
  2. mvn compile exec:java -Dexec.mainClass=oauth.v2.OAuthV2CompleteShortTokenRotation and check the response.

Every example compiles against the SDK changes. With a real short token, the rotation begun by oauth.v2.beginShortTokenRotation finishes here within 10 minutes.

🤖 Generated with Claude Code

@zimeg
zimeg force-pushed the zimeg-feat-oauth-v2-examples-begin-short-token-rotation branch from b221e04 to 5bb3a97 Compare November 18, 2026 06:17
@zimeg
zimeg force-pushed the zimeg-feat-oauth-v2-examples-complete-short-token-rotation branch from 12c96ce to a1ab359 Compare November 18, 2026 06:17
@zimeg

zimeg commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

Closing for now. Short-secret tokens only exist for apps created before August 2016, so these rotation methods aren't in scope for this release.

@zimeg zimeg closed this Nov 18, 2026
@zimeg
zimeg deleted the zimeg-feat-oauth-v2-examples-complete-short-token-rotation branch November 18, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java Pull requests that update java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant