Repository navigation
Conversation
This was referenced Nov 18, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1709 +/- ##
============================================
- Coverage 73.95% 73.85% -0.10%
+ Complexity 4752 4751 -1
============================================
Files 487 487
Lines 14811 14828 +17
Branches 1536 1538 +2
============================================
- Hits 10953 10951 -2
- Misses 2943 2958 +15
- Partials 915 919 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
zimeg
changed the base branch from
zimeg-feat-entity-acknowledge-comment-action
to
main
November 18, 2026 06:15
zimeg
force-pushed
the
zimeg-feat-entity-present-comments
branch
from
November 18, 2026 06:15
116e99e to
8c573c9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the
entity.presentCommentsmethod to the sync and async clients.entityPresentCommentstakescomments(a list ofEntityComment),triggerId,cursor,canPostComment,deleteActionId,userAuthRequired,userAuthUrl, anderror.commentsis sent as a JSON array.com.slack.api.model.EntityCommentmodel for the documented comment schema, whichentity.acknowledgeCommentActionshares in the next layer.senderandreplyUsersreuseEntityMetadata.EntityPayload.User, the work object user type the docs point to, andcomment.blocksis aRichTextBlock.errortakes the same object asentity.presentDetails(EntityPresentDetailsRequest.Error, sent as JSON). The docs page gives it no type and its example sends a string, but the API rejects a string withinvalid_arguments("must provide an object") and wants astatus.RequestFormBuilderTestchecks the JSON sent forcomments, including a rich text block.This is part 1 of 2 in the
entitystack, which adds theentitymethods one at a time. This pull request is in batch B9 work object comments. Each pull request builds on the one before it and merges on its own, bottom to top. The stack starts onmain.entity.presentComments👈 this pull requestentity.acknowledgeCommentActionTesting
Run the remote tests for this layer:
test_with_remote_apis.methods.entity_Test#presentComments+presentCommentsErrorwithSLACK_SDK_TEST_BOT_TOKENA
trigger_idcomes from theentity_comments_requestedevent for a work object flexpane, so the test sends both example comments from the docs page, a Slack user's comment with a rich text block and an external user's threaded reply, with the exampletrigger_id. The API answers with the documentedinvalid_trigger_id. It validatescommentsfirst, so anidover 25 characters returnsinvalid_argumentsinstead, and the error shows the comments' shape was accepted.presentCommentsErrorsends an error object withstatuscustomand gets the sameinvalid_trigger_id, where a stringerroror a missingstatusreturnsinvalid_arguments.Each layer was checked against the live API by running its own remote test, along with the earlier tests in its stack.
Category
Requirements
🤖 Generated with Claude Code