Rollup of 5 pull requests by JonathanBrouwer · Pull Request #159465 · rust-lang/rust

JonathanBrouwer · 2026-07-17T21:17:33Z

Successful merges:

Move std::io::Read to alloc::io #158544 (Move std::io::Read to alloc::io)
DeeplyNormalize and normalize_with_depth_to take Unnormalized<T> as input #158668 (DeeplyNormalize and normalize_with_depth_to take Unnormalized<T> as input)
[tiny] Use multipart suggestion for finding ident when literal was expected in attr #157514 ([tiny] Use multipart suggestion for finding ident when literal was expected in attr)
improve diagnostic suggestion when matching struct variants with tuple #158748 (improve diagnostic suggestion when matching struct variants with tuple)
triagebot: tweak wording for miri changes message #159463 (triagebot: tweak wording for miri changes message)

Failed merges:

Emit all borrowck errors at the end of borrowck #158916 (Emit all borrowck errors at the end of borrowck)

r? @ghost

Create a similar rollup

Co-Authored-By: Clar Fon <15850505+clarfonthey@users.noreply.github.com>

…in attr

…malized<T> as input 2. add unnormalized producing API's 3. merge Deeply Normalize and Normalize 4. make normalize_with_category accept unnormalized

…e syntax - update `report_unexpected_variant_res` to suggest using proper struct usage instead of stating that fields are being ignored. - add edge test cases in `tests/ui/parser/recover/recover-from-bad-variant.rs`

…fonthey Move `std::io::Read` to `alloc::io` ACP: rust-lang/libs-team#755 Tracking issue: rust-lang#154046 Split From: rust-lang#156527 ~~Blocked On: rust-lang#158541 ## Description Moves `std::io::Read` to `alloc::io`. This is mostly a direct cut and paste, but with a large diff due to how many implementations need to be moved into `alloc`. Blocked on rust-lang#158541. There is some new code written for some of the `Read` implementations to account for the `no_global_oom_handling` configuration, since `Vec::extend_from_slice` and `String::push_str` are unavailable. I've highlighted all of these such instances with review comments for clarity. --- ## Notes * No AI tooling of any kind was used during the creation of this PR. * Please see rust-lang#154046 (comment) for a review order and broader context for this PR.

@lcnr

…ized, r=lcnr `DeeplyNormalize` and `normalize_with_depth_to` take `Unnormalized<T>` as input part of rust-lang#155345 r? @lcnr

…thanBrouwer [tiny] Use multipart suggestion for finding ident when literal was expected in attr Minor rendering tweak.

…on, r=hanna-kruppe improve diagnostic suggestion when matching struct variants with tuple fixes rust-lang#158641 changes: passed `sub_pats` from `resolve_pat_tuple_struct` into `report_unexpected_variant_res`, match user's variable names to struct fields, fix suggestion name.

@oli-obk

triagebot: tweak wording for miri changes message Hopefully make it less likely that people think they should make a Miri PR when they shouldn't. r? @oli-obk

JonathanBrouwer · 2026-07-17T21:17:50Z

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-*

rust-bors · 2026-07-17T21:17:52Z

📌 Commit 2b64898 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 5 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-*

rust-bors · 2026-07-18T00:24:45Z

☀️ Try build successful (CI)
Build commit: 1f5040d (1f5040de296e44f085b511e4440a434eeac99e43)
Base parent: 421875f (421875f8d2bbb9a9a47db179092a3266b87106d4)

rust-bors · 2026-07-18T02:45:57Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 29m 32s
Pushing 6372368 to main...

rust-timer · 2026-07-18T02:47:27Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#158544	Move `std::io::Read` to `alloc::io`	`7358955be5a4ab88b176193afb381fc73e208245` (link)
#158668	`DeeplyNormalize` and `normalize_with_depth_to` take `Unnor…	`e011bec065422d7295aa52620d7f147149128172` (link)
#157514	[tiny] Use multipart suggestion for finding ident when lite…	`2ebb98008964d743e387894a55d6212a7b085db9` (link)
#158748	improve diagnostic suggestion when matching struct variants…	`eec66414d4146d4b03aceeb583c2f7b6a1b7242b` (link)
#159463	triagebot: tweak wording for miri changes message	`657ea0c19400bbcfe95c741f6e1079b25571f8aa` (link)

previous master: b6839f4d0e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-07-18T02:49:13Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b6839f4 (parent) -> 6372368 (this PR)

Test differences

Show 410 test diffs

410 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 637236889f3c7668c43cc4a9bb75691e85dacf2a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-gcc-core-tests: 8m -> 14m 15s (+77.9%)
x86_64-msvc-ext2: 1h 21m -> 1h 57m (+44.5%)
x86_64-gnu-next-trait-solver-polonius: 40m 19s -> 58m 10s (+44.3%)
dist-x86_64-solaris: 1h 7m -> 1h 36m (+43.1%)
i686-gnu-nopt-2: 2h 21m -> 1h 28m (-37.7%)
x86_64-gnu-llvm-22-3: 1h 26m -> 1h 54m (+31.3%)
dist-armhf-linux: 1h 33m -> 1h 4m (-30.8%)
x86_64-msvc-2: 2h 32m -> 1h 45m (-30.7%)
i686-gnu-nopt-1: 1h 54m -> 2h 24m (+25.9%)
dist-x86_64-linux-alt: 1h 55m -> 2h 24m (+25.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-07-18T03:27:51Z

Finished benchmarking commit (6372368): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.6%, secondary -1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.2%	[3.2%, 3.2%]	1
Regressions ❌ (secondary)	4.4%	[2.2%, 5.2%]	5
Improvements ✅ (primary)	-4.0%	[-5.8%, -2.2%]	2
Improvements ✅ (secondary)	-7.6%	[-12.0%, -2.5%]	5
All ❌✅ (primary)	-1.6%	[-5.8%, 3.2%]	3

Cycles

Results (primary -2.2%, secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Binary size

Results (primary 0.2%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.3%]	8
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	1
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	0.2%	[-0.0%, 0.3%]	9

Bootstrap: 490.163s -> 488.864s (-0.27%)
Artifact size: 390.10 MiB -> 390.05 MiB (-0.01%)

bushrat011899 and others added 14 commits July 10, 2026 15:23

Move std::io::Read internals to alloc::io

a2f9d61

Move std::io::append_to_string to alloc::io

b06ba03

Move std::io::Read to alloc::io

032721c

Promote comments in alloc::io::read to documentation

9fafa9b

Co-Authored-By: Clar Fon <15850505+clarfonthey@users.noreply.github.com>

Replace alloc::io::read::Guard with core::mem::DropGuard

d1bdecc

Co-Authored-By: Clar Fon <15850505+clarfonthey@users.noreply.github.com>

Use multipart suggestion for finding ident when literal was expected …

6bf3fbe

…in attr

1. DeeplyNormalize QueryTpeOp and normalize_with_depth_to takes Unnor…

3a8dea3

…malized<T> as input 2. add unnormalized producing API's 3. merge Deeply Normalize and Normalize 4. make normalize_with_category accept unnormalized

triagebot: tweak wording for miri changes message

960d9c5

Rollup merge of rust-lang#158668 - Shourya742:2026-07-01-use-unnormal…

84d3495

…ized, r=lcnr `DeeplyNormalize` and `normalize_with_depth_to` take `Unnormalized<T>` as input part of rust-lang#155345 r? @lcnr

Rollup merge of rust-lang#157514 - estebank:attr-expected-lit, r=Jona…

cadbb17

…thanBrouwer [tiny] Use multipart suggestion for finding ident when literal was expected in attr Minor rendering tweak.

Rollup merge of rust-lang#159463 - RalfJung:triagebot-miri, r=oli-obk

2b64898

triagebot: tweak wording for miri changes message Hopefully make it less likely that people think they should make a Miri PR when they shouldn't. r? @oli-obk

rust-bors Bot added the rollup A PR which is a rollup label Jul 17, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2026

rust-bors Bot merged commit 6372368 into rust-lang:main Jul 18, 2026
15 checks passed

rustbot added this to the 1.99.0 milestone Jul 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 5 pull requests#159465

Rollup of 5 pull requests#159465
rust-bors[bot] merged 14 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-rGY6BWp

JonathanBrouwer commented Jul 17, 2026

Uh oh!

JonathanBrouwer commented Jul 17, 2026

Uh oh!

rust-bors Bot commented Jul 17, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jul 18, 2026

Uh oh!

rust-bors Bot commented Jul 18, 2026

Uh oh!

Uh oh!

rust-timer commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

rust-timer commented Jul 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Jul 17, 2026

Uh oh!

JonathanBrouwer commented Jul 17, 2026

Uh oh!

rust-bors Bot commented Jul 17, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jul 18, 2026

Uh oh!

rust-bors Bot commented Jul 18, 2026

Uh oh!

Uh oh!

rust-timer commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 18, 2026

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants