Emit all borrowck errors at the end of borrowck#158916
Open
oli-obk wants to merge 4 commits into
Open
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
help! @rust-lang/rustdoc what is this error and how can it possibly be caused from borrowck changes? |
Member
|
It's a flaky error. Should be fixed once #158913 is merged. Restarted failed jobs. |
lcnr
reviewed
Jul 13, 2026
lcnr
reviewed
Jul 13, 2026
| impl<'diag, 'tcx> crate::MirBorrowckCtxt<'_, 'diag, 'tcx> { | ||
| pub(crate) fn dcx(&self) -> DiagCtxtHandle<'diag> { | ||
| self.infcx.dcx() | ||
| self.root_cx.dcx() |
Contributor
There was a problem hiding this comment.
ah here
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
borrowck-delayed-diags
branch
from
July 17, 2026 13:57
f06dbe0 to
ac3b398
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=lcnr |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 17, 2026
…uwer Rollup of 5 pull requests Successful merges: - #158544 (Move `std::io::Read` to `alloc::io`) - #158668 (`DeeplyNormalize` and `normalize_with_depth_to` take `Unnormalized<T>` as input) - #157514 ([tiny] Use multipart suggestion for finding ident when literal was expected in attr) - #158748 (improve diagnostic suggestion when matching struct variants with tuple) - #159463 (triagebot: tweak wording for miri changes message) Failed merges: - #158916 (Emit all borrowck errors at the end of borrowck)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc rust-lang/rust-project-goals#713
best reviewed commit by commit.
This changes some diagnostic ordering and tainting effects on diagnostics, but generally that should be an improvement as all diagnostics are sorted by their line numbers now
r? @lcnr