Move std::io::BufRead to alloc::io#158546
Conversation
|
r? @clarfonthey rustbot has assigned @clarfonthey. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@rustbot blocked |
This comment has been minimized.
This comment has been minimized.
cd4c8b8 to
e1864c0
Compare
This comment has been minimized.
This comment has been minimized.
17bb815 to
2adb28d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2adb28d to
72b16b3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
72b16b3 to
159a7a4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
159a7a4 to
8b44677
Compare
This comment has been minimized.
This comment has been minimized.
8b44677 to
964cd84
Compare
This comment has been minimized.
This comment has been minimized.
964cd84 to
82b55ba
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6c1ff9d to
ad05ab8
Compare
This comment has been minimized.
This comment has been minimized.
ad05ab8 to
982072a
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Congratulations Clar Fon, you're already assigned this one! Label was from the blocked earlier version of this PR. The rustdoc labels are just because one of the tests has a slightly different path now that a buffered item is now defined in |
|
Seems straightforward, minus one small thing. Otherwise LGTM. |
More consistent with the default functions for `Read` Co-Authored-By: Clar Fon <15850505+clarfonthey@users.noreply.github.com>
|
@bors r+ |
…clarfonthey Move `std::io::BufRead` to `alloc::io` ACP: rust-lang/libs-team#755 Tracking issue: rust-lang#154046 Split From: rust-lang#156527 ~~Blocked On: rust-lang#158545 ## Description Moves `std::io::BufRead` to `alloc::io`. This is effectively a direct cut and paste, but with a large diff due to how many implementations need to be moved into `alloc`. Blocked on rust-lang#158545. --- ## Notes * No AI tooling of any kind was used during the creation of this PR. * Please see rust-lang#154046 (comment) for a review order and broader context for this PR.
…clarfonthey Move `std::io::BufRead` to `alloc::io` ACP: rust-lang/libs-team#755 Tracking issue: rust-lang#154046 Split From: rust-lang#156527 ~~Blocked On: rust-lang#158545 ## Description Moves `std::io::BufRead` to `alloc::io`. This is effectively a direct cut and paste, but with a large diff due to how many implementations need to be moved into `alloc`. Blocked on rust-lang#158545. --- ## Notes * No AI tooling of any kind was used during the creation of this PR. * Please see rust-lang#154046 (comment) for a review order and broader context for this PR.
Rollup of 5 pull requests Successful merges: - #158546 (Move `std::io::BufRead` to `alloc::io`) - #159372 (Remove SIZE generic param from DisplayBuffer in core::net) - #159548 (miri subtree update) - #159508 (Some cleanup in `rustc_attr_parsing`) - #159539 ([rustc_abi] Customize `Debug` for `Primitive` and `Scalar`)
Rollup merge of #158546 - bushrat011899:alloc_io_bufread, r=clarfonthey Move `std::io::BufRead` to `alloc::io` ACP: rust-lang/libs-team#755 Tracking issue: #154046 Split From: #156527 ~~Blocked On: #158545 ## Description Moves `std::io::BufRead` to `alloc::io`. This is effectively a direct cut and paste, but with a large diff due to how many implementations need to be moved into `alloc`. Blocked on #158545. --- ## Notes * No AI tooling of any kind was used during the creation of this PR. * Please see #154046 (comment) for a review order and broader context for this PR.
View all comments
ACP: rust-lang/libs-team#755
Tracking issue: #154046
Split From: #156527
Blocked On: #158545Description
Moves
std::io::BufReadtoalloc::io. This is effectively a direct cut and paste, but with a large diff due to how many implementations need to be moved intoalloc. Blocked on #158545.Notes
alloc::ioandcore::io#154046 (comment) for a review order and broader context for this PR.