Skip to content

[ET-VK] Add ANY_STORAGE support to softmax and log_softmax#18054

Open
SS-JIA wants to merge 1 commit intogh/SS-JIA/471/basefrom
gh/SS-JIA/471/head
Open

[ET-VK] Add ANY_STORAGE support to softmax and log_softmax#18054
SS-JIA wants to merge 1 commit intogh/SS-JIA/471/basefrom
gh/SS-JIA/471/head

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Mar 10, 2026

Stack from ghstack (oldest at bottom):

Add a buffer shader variant for softmax using workgroup-based reduction with
shared memory. The buffer shader dispatches one workgroup per "row" along the
reduction dimension, with NWORKERS=4 threads per workgroup cooperating on the
max and sum reductions before writing outputs.

In Softmax.cpp, the existing texture dispatch is renamed add_softmax_texture_node
and new add_softmax_buffer_node / add_softmax_node dispatch functions are added.
op_registry.py is updated from ANY_TEXTURE to ANY_STORAGE so the partitioner
accepts buffer-storage inputs. Test cases now also exercise buffer storage.

Differential Revision: D95970171

Add a buffer shader variant for softmax using workgroup-based reduction with
shared memory. The buffer shader dispatches one workgroup per "row" along the
reduction dimension, with NWORKERS=4 threads per workgroup cooperating on the
max and sum reductions before writing outputs.

In Softmax.cpp, the existing texture dispatch is renamed add_softmax_texture_node
and new add_softmax_buffer_node / add_softmax_node dispatch functions are added.
op_registry.py is updated from ANY_TEXTURE to ANY_STORAGE so the partitioner
accepts buffer-storage inputs. Test cases now also exercise buffer storage.

Differential Revision: [D95970171](https://our.internmc.facebook.com/intern/diff/D95970171/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 10, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18054

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Cancelled Jobs

As of commit 9ca763e with merge base f09bd55 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant