Skip to content

[ET-VK] Add symint infrastructure to VulkanBackend and ComputeGraph#18050

Open
SS-JIA wants to merge 1 commit intogh/SS-JIA/467/basefrom
gh/SS-JIA/467/head
Open

[ET-VK] Add symint infrastructure to VulkanBackend and ComputeGraph#18050
SS-JIA wants to merge 1 commit intogh/SS-JIA/467/basefrom
gh/SS-JIA/467/head

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Mar 10, 2026

Stack from ghstack (oldest at bottom):

Extend the Vulkan backend runtime infrastructure to better support symbolic
integer (symint) arguments. This is a prerequisite for operators that need
to handle dynamic shapes via symint values.

Changes:

  • VulkanBackend.cpp: Compute output offset from end of args instead of
    assuming outputs follow inputs directly. Add scalar-to-tensor input
    handling so that Int/Bool EValues can populate tensor inputs. Support
    symint inputs provided as raw Int EValues (not just scalar tensors).
    Add symint output handling to write values back as tensor or Int EValue.
  • ComputeGraph.h: Add SymInt case to extract_scalar() so operators
    can transparently read symint values as scalars.
  • ComputeGraph.cpp: Add Int fallback in read_symint() so values stored
    as plain Int (rather than SymInt objects) can be read uniformly.

Differential Revision: D95970167

cc @manuelcandales @digantdesai @cbilgin

Extend the Vulkan backend runtime infrastructure to better support symbolic
integer (symint) arguments. This is a prerequisite for operators that need
to handle dynamic shapes via symint values.

Changes:
- VulkanBackend.cpp: Compute output offset from end of args instead of
  assuming outputs follow inputs directly. Add scalar-to-tensor input
  handling so that Int/Bool EValues can populate tensor inputs. Support
  symint inputs provided as raw Int EValues (not just scalar tensors).
  Add symint output handling to write values back as tensor or Int EValue.
- ComputeGraph.h: Add SymInt case to extract_scalar<T>() so operators
  can transparently read symint values as scalars.
- ComputeGraph.cpp: Add Int fallback in read_symint() so values stored
  as plain Int (rather than SymInt objects) can be read uniformly.

Differential Revision: [D95970167](https://our.internmc.facebook.com/intern/diff/D95970167/)

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Mar 10, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 10, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18050

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit 3070b7a with merge base f09bd55 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant