Skip to content

fix qlim, q, n - #666

Draft
LonelyPaprika wants to merge 1 commit into
petercorke:mainfrom
LonelyPaprika:fix/dampers
Draft

fix qlim, q, n#666
LonelyPaprika wants to merge 1 commit into
petercorke:mainfrom
LonelyPaprika:fix/dampers

Conversation

@LonelyPaprika

Copy link
Copy Markdown
Contributor

Summary

Related issue

Fixes #665

Checklist

Only the first item below is checked automatically — the rest are a self-check for you before requesting review, nothing currently verifies them for you.

  • PR title follows Conventional Commits (type: description) — checked automatically, see the "Check PR title" status
  • Tests pass locally (pytest)
  • Added/updated tests for this change, if applicable
  • New/changed code is type-hinted with modern syntax (X | Y, list[X], not Union/Optional/List)
  • Docstrings updated (reST style: :param:, :returns:; type hints in the signature cover types now, :type:/:rtype: are rarely needed)
  • PR is as small/focused as practical — if it tackles several unrelated things, consider splitting it so each can be reviewed and accepted independently
  • No test files, data files, or notebooks specific to your own project — PyPI has strict package size limits, and RTB is already split into a toolbox and a data package. Notebooks, if of general interest, should have output cleared before committing.

@LonelyPaprika
LonelyPaprika marked this pull request as draft September 5, 2026 15:51
@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (2d24e0d) to head (3b6fe7e).

Files with missing lines Patch % Lines
src/roboticstoolbox/robot/Robot.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #666   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        143     143           
  Lines      14050   14053    +3     
=====================================
- Misses     14050   14053    +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@petercorke

Copy link
Copy Markdown
Owner

Thanks for submitting this PR, at the moment it can't be merged because you've marked it as draft. There's a gap in testing of the examples files, and to be honest some of the examples should be discarded and the rest need some polish. The notebooks at least have a smoke test.

@LonelyPaprika

Copy link
Copy Markdown
Contributor Author

@petercorke Thanks for your answer, I am not completely sure if my approach is correct here so I will continue working on this PR and will let you know when ready. I like some of these examples so I will see if I can add a smoke test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error related to qlim when running example robotics-toolbox-python/examples/neo.py

2 participants