fix(qos): align QoS reliability, durability, and history policies across nodes#43
Merged
Conversation
…oss nodes Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
arjo129
marked this pull request as ready for review
July 21, 2026 09:20
Contributor
|
This fixed the odometry error that I reported here. Now I'm able to see a path be generated, but it remains frozen at that point: 
It seems like maybe something in the execution system is getting cut off? This happens for both Cyclone and FastDDS, but not for Zenoh. |
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Member
Author
|
13c30fb should fix that as the progress of the robot in the demo server is derived from the odometry it outputs. I'll need to put in place some regression testing for this. @luca-della-vedova also suggested using @koonpeng 's REDF package to prevent such pain. |
mxgrey
approved these changes
Jul 22, 2026
mxgrey
left a comment
mxgrey
left a comment
Contributor
There was a problem hiding this comment.
I've confirmed that the QoS changes have fixed the issue that I raised earlier 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Discovered more DDS related issues when using cycloneDDS for testing that dont seem to be caught by our tests on FastRTPS.
Fix applied
~/odomtopic (generated by Nav2/simulators) the default should follow the nav2 convention of/odomas VOLATILE + RELIABLE:We should consider consolidating behaviour using some crate that sets constants/python package, so that we don't burn ourselves again.
Generated-by: