Conversation
… signature hashes This reverts commit d8b12fc. Executes the maintainer's ruling recorded verbatim on the card that carries this work: option C, revert the PR and let consumer compilation against spec@main be the shape gate instead. The direction is not re-argued here. One conflict, resolved mechanically. api-surface-declarations/root.txt was regenerated on main after the reverted commit; the revert deletes the whole directory, so that file goes with it (git rm). Nothing else in the reverted commit's file set needed a decision. The one path this branch does NOT restore to the reverted commit's parent is .github/workflows/lint.yml, which keeps the later, unrelated check:release-spec-changes step. Reverting that step is not this revert's business. Claude-Session: https://claude.ai/code/session_01JbZnqu8bt6YqfJsr9vaFb3 Co-authored-by: Claude <noreply@anthropic.com>
📓 Docs Drift Check
What this run could not see
Coarse fallback — 136 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
Two modify/delete conflicts, both the same mechanical shape as the one the revert itself carried: api-surface-declarations/automation.txt and data.txt were regenerated on main while this branch deletes the whole directory, so the files go with it (git rm). Nothing else in the merge needed a decision. Claude-Session: https://claude.ai/code/session_01JbZnqu8bt6YqfJsr9vaFb3 Co-authored-by: Claude <noreply@anthropic.com>
|
Skills-lane reading of the Read at
This is a reading, not a review of record: the revert is the spec seat's (os-bill, #19011), Generated by Claude Code |
|
席位记录( ①
|
Main regenerated packages/spec/api-surface-declarations/ui.txt after this branch deleted the directory, so the merge raised the same modify/delete it raised once before. Resolved the same mechanical way: git rm, because the revert removes the whole directory. Re-verified on the merge result: of the 31 paths the reverted commit touched, 30 are byte-identical to its parent; the one that is not is .github/workflows/lint.yml, whose only difference is the check:release-spec-changes step a LATER commit added, compared hunk body to hunk body and identical. api-surface-signatures.json is back with its 27 top-level keys, defineAction through defineWebhook. Claude-Session: https://claude.ai/code/session_01JbZnqu8bt6YqfJsr9vaFb3 Co-authored-by: Claude <noreply@anthropic.com>
Fixes #19011
Reverts PR #18971 (squash commit
d8b12fca9) under the maintainer's ruling C, recorded verbatim on the card: the 12 MiB declaration-text snapshot comes out, and consumer compilation againstspec@mainbecomes the shape gate instead. ⛔ The direction is not re-argued here.The branch was produced by the dispatched
domain:specseat (claim comment on #19011,session_01JbZnqu8bt6YqfJsr9vaFb3); this PR only opens it for review.What lands
git revert d8b12fca9, 31 files, +119 / −238,361:packages/spec/api-surface-declarations/(17 shards, 237,706 lines) and its generatorpackages/spec/scripts/build-api-surface-declarations.ts;packages/spec/api-surface-signatures.json(the 27 hashes) as the interim shape pin;scripts/regen-artifacts.mjs,scripts/pm/check-widening-tells.mjs,scripts/pm/dispatch-gates.mjs(CLASS_EIGHTH),scripts/check-published-files.mjs,.github/workflows/lint.yml,.gitattributes,docs/spec-generated-artifact-sharding.md,packages/spec/package.json(files[]);.changeset/16045-spec-declaration-text-snapshots.md.Faithfulness, measured rather than asserted
Of the 31 files #18971 touched, 30 are restored byte-for-byte to the reverted commit's parent
a48496640— compared by blob sha, not by eye.The one path that is deliberately not restored is
.github/workflows/lint.yml, which keeps the later, unrelatedcheck:release-spec-changesself-test step (#18889, landed after #18971). Reverting that step is not this revert's business; the diff against the parent blob is exactly those 12 lines and nothing else.Merges cleanly into
origin/mainat9ee8e3510(git merge-tree --write-tree, no conflict).Why no changeset
skip-changeset: #18971 was never released — its own changeset was still pending onmain. Reverting the code and its pending changeset leaves the next release byte-identical to what it would have been before #18971 landed, so this PR releases nothing. An empty-frontmatter changeset is not a route (#5471).Landing
⛔ Not a seat's landing. Under the maintainer's second ruling of the same exchange (「修改代码量超过某个行数(比如5000)就应该人工审核」), a 238,480-line PR is maintainer-landed. Opened as a draft; review requested from
GOVERNED_APPROVERS.Not in this card
The consumer-compile gate that replaces the snapshot — objectui's half is filed on objectui; cloud's half is outside this session's write scope and was named to the maintainer in chat.
🤖 Generated with Claude Code