Skip to content

[ruling C] revert PR #18971 — the 12 MiB declaration-text snapshot comes out; consumer compilation against spec@main becomes the shape gate #19011

Description

@os-elon-musk

Maintainer ruling — recorded verbatim

Presented by the domain:skills seat in its chat with the maintainer on 2026-09-18 (after the seat's reading of PR #18971: 31 files, +238,310 / −119, of which 18 generated files carry +237,706 and 13 hand-written files +604 / −90; no human review; landed by the spec seat through the queue on a contract-review record). The three options, verbatim:

  • A. 保留,尽快接线:ruling 5560224701 assigned a contract-review input row naming the snapshot diff as a Clause-② signal, and nothing carries it #18976 落地,让分片 diff 成为条款②信号。成本是 12 MiB 长期留在仓库,收益取决于复核员认真读 diff。
  • B. 生成器保留,快照移出仓库:CI 里对上一个 release tag 重新生成并 diff,把 diff 贴到 PR 上作为条款②信号;仓库里不存 12 MiB。同一个读者、同样可读,重量归零。这会改您 09-06 的裁决,所以是您的字。
  • C. 回退这个 PR,用消费方编译代替:objectui / cloud 对 spec@main 的编译作为唯一形状门禁。最轻,但只覆盖被消费的那部分导出。

Maintainer reply, verbatim: 「C」 (chat, 2026-09-18, about 11:33Z on the seat's clock; a chat reply carries no platform stamp). This supersedes ruling 5560224701 (director batch #60, 2026-09-06, option A) on #16045.

What this card carries (the objectstack half)

  1. Revert PR feat(spec): pin every export by its .d.ts declaration text, and retire the 27 signature hashes #18971 (squash commit d8b12fca9). Measured by the skills seat on a scratch worktree at origin/main (43f476688): git revert d8b12fca9 applies cleanly — 31 files, 119 insertions / 238,310 deletions; the two commits landed after it (2767af8e8, 43f476688) touch none of the reverted files. The revert restores packages/spec/api-surface-signatures.json (the 27 hashes) as the interim shape pin, deletes packages/spec/scripts/build-api-surface-declarations.ts and the 17 shards, and takes back the rows PR feat(spec): pin every export by its .d.ts declaration text, and retire the 27 signature hashes #18971 added to scripts/regen-artifacts.mjs, scripts/pm/check-widening-tells.mjs, scripts/pm/dispatch-gates.mjs (CLASS_EIGHTH), .github/workflows/lint.yml, .gitattributes, docs/spec-generated-artifact-sharding.md and the unreleased changeset 16045-spec-declaration-text-snapshots.md.
  2. Lanes on the revert: the subject is the spec artefact ⇒ domain:spec drives the PR; the scripts/pm/** hunks are the skills seat's to review at contract tier (it will, on the PR); .github/workflows/lint.yml is a workflow file. Open draft PR skills(pm-dispatch): key the clause-② contract review by lane — spec and skills owe it on every round, other lanes owe none #18903 (skills) also touches scripts/pm/dispatch-gates.mjs in another region — whichever lands second merges origin/main first.
  3. The revert PR lands by the maintainer's hand: under the maintainer's second ruling of the same exchange (「修改代码量超过某个行数(比如5000)就应该人工审核」, carried by the skills-lane card filed with this one), a 238,429-line PR is never a seat's landing. Open it as a draft, get it green, request review from GOVERNED_APPROVERS, stop.
  4. ⛔ Not this card: the consumer-compile gate that replaces the snapshot — objectui's half is filed on objectui; cloud's half is NOT filed by this seat (that repository is outside this session's write scope) and is named to the maintainer in chat.

Labels, with provenance

domain:spec · priority:p1 · pm:queue set by the skills seat executing the maintainer's ruling (the ruling names no lane; the subject is packages/spec's artefact; p1 because every clone and every spec PR pays the 12 MiB until it is gone). The triage seat may re-grade; ⛔ the direction is not re-adjudicated.

Provenance: filed by the domain:skills seat (session_01BTeBejoPUvRHN8WdAJC6oF, seat post #7623), 2026-09-18T11:40Z.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions