Repository navigation
test(controller): catch parsing and permission regressions (stack 4/4) - #251
Open
benvinegar wants to merge 1 commit into
Open
benvinegar wants to merge 1 commit into
benvinegar wants to merge 1 commit into
Conversation
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A parsing change can swallow a task's
--help, select the wrong host or let a permission change happen before approval. Hand-picked tests can also miss new commands.Change
Build tests from the command declarations, and fail when a new terminal rule, payload type or alias has no test case.
Check argument handling, real-terminal approval and attach behavior, rejected session names, exit codes and signals. Run suggested follow-up commands to verify they reach the right host, and check that grant listings never fetch secret values.
The tests use temporary homes and stubbed transports, not real hosts. No production code changes.
Tests
Lint, typecheck and shell tests passed; unit tests: 519 passed, 1 skipped, including 30 new cases.
Stack 4/4: #246 → #249 → #250 → #251. Based on #250's branch; merge that first.