Skip to content

test(controller): catch parsing and permission regressions (stack 4/4) - #251

Open
benvinegar wants to merge 1 commit into
docs/cli-read-only-vs-offlinefrom
test/cli-boundaries
Open

benvinegar wants to merge 1 commit into
docs/cli-read-only-vs-offlinefrom
test/cli-boundaries

Conversation

@benvinegar

@benvinegar benvinegar commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Problem

A parsing change can swallow a task's --help, select the wrong host or let a permission change happen before approval. Hand-picked tests can also miss new commands.

Change

Build tests from the command declarations, and fail when a new terminal rule, payload type or alias has no test case.

Check argument handling, real-terminal approval and attach behavior, rejected session names, exit codes and signals. Run suggested follow-up commands to verify they reach the right host, and check that grant listings never fetch secret values.

The tests use temporary homes and stubbed transports, not real hosts. No production code changes.

Tests

Lint, typecheck and shell tests passed; unit tests: 519 passed, 1 skipped, including 30 new cases.

Stack 4/4: #246 → #249 → #250 → #251. Based on #250's branch; merge that first.

@benvinegar benvinegar changed the title test(controller): enforce command boundary contracts (stack 4/4) test(controller): catch parsing and permission regressions (stack 4/4) Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant