Skip to content

fix(controller): make follow-up commands copyable (stack 2/4) - #249

Merged
benvinegar merged 1 commit into
feat/cli-command-contractsfrom
feat/cli-canonical-hints
Nov 9, 2026
Merged

benvinegar merged 1 commit into
feat/cli-command-contractsfrom
feat/cli-canonical-hints

Conversation

@benvinegar

@benvinegar benvinegar commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Problem

After grouping the CLI into families, follow-up messages still suggested old command names. Writing each hint by hand also made it easy to forget --host or mishandle spaces and quotes.

Change

Use one formatter that checks command names, quotes arguments and keeps the explicit host. Job hints now suggest job logs and job wait; lease and grant hints use their new families too.

Grant requests always name the host, even when it was the default, so someone copying the command cannot grant access on the wrong host. Shared MCP approval messages and command output formats stay unchanged.

Tests

Lint, typecheck and shell tests passed; unit tests: 489 passed, 1 skipped. Added quoting and copy/paste tests.

Stack 2/4: #246 → #249 → #250 → #251. Based on #246's branch; merge that first.

@benvinegar benvinegar changed the title fix(controller): render canonical follow-up commands (stack 2/4) fix(controller): make follow-up commands copyable (stack 2/4) Nov 9, 2026
@benvinegar
benvinegar merged commit f18a404 into feat/cli-command-contracts Nov 9, 2026
17 of 18 checks passed
benvinegar added a commit that referenced this pull request Nov 9, 2026
* feat(controller): declare command execution contracts (stack 1/4)

* fix(controller): render canonical follow-up commands (stack 2/4) (#249)

* test(controller): preserve job error statuses after hint rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant