Repository navigation
fix(controller): make follow-up commands copyable (stack 2/4) - #249
Merged
Merged
Conversation
benvinegar
added a commit
that referenced
this pull request
Nov 9, 2026
benvinegar
added a commit
that referenced
this pull request
Nov 9, 2026
* feat(controller): declare command execution contracts (stack 1/4) * fix(controller): render canonical follow-up commands (stack 2/4) (#249) * test(controller): preserve job error statuses after hint rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After grouping the CLI into families, follow-up messages still suggested old command names. Writing each hint by hand also made it easy to forget
--hostor mishandle spaces and quotes.Change
Use one formatter that checks command names, quotes arguments and keeps the explicit host. Job hints now suggest
job logsandjob wait; lease and grant hints use their new families too.Grant requests always name the host, even when it was the default, so someone copying the command cannot grant access on the wrong host. Shared MCP approval messages and command output formats stay unchanged.
Tests
Lint, typecheck and shell tests passed; unit tests: 489 passed, 1 skipped. Added quoting and copy/paste tests.
Stack 2/4: #246 → #249 → #250 → #251. Based on #246's branch; merge that first.