Skip to content

refactor(controller): keep command rules in one place (stack 1/4) - #246

Merged
benvinegar merged 3 commits into
masterfrom
feat/cli-command-contracts
Nov 9, 2026
Merged

benvinegar merged 3 commits into
masterfrom
feat/cli-command-contracts

Conversation

@benvinegar

@benvinegar benvinegar commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Problem

Command rules were scattered through the dispatcher: which commands need a host, which need a terminal, and when --help is an option rather than text to send to a VM. Adding a command meant remembering those special cases.

Change

Keep those rules next to each command's handler. The dispatcher and tests read the same declarations, and family actions inherit their handler's rules. Existing command behavior stays the same.

Tests

Lint, typecheck and shell tests passed; unit tests: 484 passed, 1 skipped.

Stack 1/4: #246 → #249 → #250 → #251. Merge in order; rebase/retarget the next PR after a squash merge.

@benvinegar benvinegar changed the title feat(controller): declare command execution contracts (stack 1/4) refactor(controller): keep command rules in one place (stack 1/4) Nov 9, 2026
@benvinegar
benvinegar force-pushed the feat/cli-command-contracts branch from f18a404 to c9370fa Compare November 9, 2026 02:22
@benvinegar
benvinegar merged commit 94a51ed into master Nov 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant