Skip to content

refactor(code-metrics): audit router wave 1 of 5 (router, size, complexity, type-debt) #12619

Closed as not planned
2 of 2 issues completed
Closed as not planned

Description

@kyle-sexton

Refs #12491

Blocked by #12486

Outcome

Wave 1 of 5 in the #12491 sized wave plan. It creates the code-metrics:audit router at plugins/code-metrics/skills/audit/ (SKILL.md, actions/, scripts/, evals/) and moves audit-size, audit-complexity and audit-type-debt into it, each as actions/<metric>.md, with their scripts under scripts/. The three leaf directories are removed, and every reference to the three names is repointed in this wave, with no aliases.

  • Measured mechanical move: 189,588 bytes of git diff --no-renames at b92833d99a. The router SKILL.md adds up to about 20 KB on top, under the 5,000-token cap (plugins/playbooks/skills/skill-authoring/reference/skill-criteria.md:142).
  • audit-coverage.sh calls skills/audit-complexity/scripts/audit-complexity.sh; repoint it to skills/audit/scripts/.
  • Also repoint prerequisites.json (skill:audit-type-debt, skill:audit-complexity) and scripts/check-code-metrics-skill-prose.py.
  • The report skill field values, the dispatch.sh id argument and the detector rule ids keep their old values (refactor(code-metrics): give the six audit-* skills distinct, trimmed descriptions #12491 plan, "Contracts that keep their values").

Done when

  • Before the move, the three skills' evals/evals.json cases are converted with convert-evals-json.py (plugins/evals/skills/plugin-eval/SKILL.md:436), and before.json is captured on the pre-move tree.
  • /evals:plugin-eval --baseline before.json --margin 5 passes at non-inferiority on the moved actions.
  • git diff --no-renames origin/main of the PR is under 262144 bytes, or the wave is split.
  • ls -d plugins/code-metrics/skills/audit-* | wc -l is 3.
  • scripts/validate-plugins.sh passes, and a merge probe is posted per D82/Q186.

Related

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 3, 2026
  2. github-actions commented on Nov 3, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: structural
    Basis: automated intake triage; the lanes App applied this class.

    Size: Large
    Complexity: Medium
    Uncertainty: Known
    Flags: none
    Blocked by: none

    Understood: wave 1 of 5 from the #12491 plan. It creates the code-metrics:audit router and moves audit-size, audit-complexity and audit-type-debt into it as actions. Scripts move under scripts/, and every reference to the old names is repointed with no aliases. The scope and done-when items are exact. The issue already states the split rule: split the wave if the diff reaches 262144 bytes. Its 189,588-byte move plus about 20 KB of router fits under that. The earlier PR #12641 was closed unmerged, so the work is re-entering intake. #12486 is not in the open-issue list I was given, so I treated that blocker as cleared. No duplicates found.

    Automated triage, applied by the lanes App.

  3. added
    priority: mediumReal value, no hard deadline; normal backlog flow.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 3, 2026
  4. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    work-class: structuralRefactors, migrations, contract changes; cross-cutting and hard to reverse.
    on Nov 3, 2026
  5. melodic-automation-lanes commented on Nov 3, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane yet: sub-issue #12919 is open; sub-issue #12920 is open.

  6. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 3, 2026
  7. github-actions commented on Nov 3, 2026

    @github-actions
    Contributor
    No description provided.
  8. github-actions commented on Nov 3, 2026

    @github-actions
    Contributor
    No description provided.
  9. melodic-automation-lanes commented on Nov 3, 2026

    @melodic-automation-lanes
    Contributor

    The lanes App's pull request #12641 for this issue was closed without merging. work-unblock removed status: ready and agent-ready, so the hourly triage sweep sends it back to intake triage, which decides what work is left and admits it again.

  10. removed
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 3, 2026
  11. github-actions commented on Nov 3, 2026

    @github-actions
    Contributor

    The triage sweep dispatched intake triage for this issue (dispatch 1; 2 runs that reach intake, or 6 dispatches, hand it to a maintainer).

  12. melodic-automation-lanes commented on Nov 3, 2026

    @melodic-automation-lanes
    Contributor

    Split at intake (owner Q93). This issue is Size Large, so its done-when is split into 2 sub-issues, each holding its task-list lines as written.

    Automated split by the lanes App. Admission waits on this issue while a sub-issue is open; work-unblock closes it as completed once every sub-issue is closed as completed by a merge or a listed human and its done-when is covered.

  13. kyle-sexton commented on Nov 3, 2026

    @kyle-sexton
    MemberAuthor

    Closed not planned: the owner re-scoped #12491 to option 3 (keep the leaves, distinct trimmed descriptions) and dropped the router merge and its waves: #12491 (comment). The remaining work is #12491 itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: mediumReal value, no hard deadline; normal backlog flow.work-class: structuralRefactors, migrations, contract changes; cross-cutting and hard to reverse.

    Type

    Fields

    Work status

    ready

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions